Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup part 2 for 5.14 #11366

Merged
merged 19 commits into from
Aug 29, 2019
Merged

Rollup part 2 for 5.14 #11366

merged 19 commits into from
Aug 29, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 28, 2019

Description

This rollup contains PRs:

#11348
#11337
#11334
#11296
#11290
#11248

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Marcin Radomski and others added 19 commits August 16, 2019 14:14
Some tests depend on that behavior.
For memories like MX25LM51245G that do not support dual or quad read (in
this case because it supports single and octo-IO modes)
This could cause incomplete data retrieval and mismatch when reading
data in more than one chunk, because every chunk would be read to the
same location at the beginning of the output buffer.
For STM32 platforms that embed an OSPI IP, we're offering
a QSPI fallback support with this commit.

When OSPI is supported in mbed, we can consider adding full
OSPI support
Keep former behaviour for I2C V1.
For I2C V2:
Use only I2C_FIRST_FRAME, I2C_FIRST_AND_LAST_FRAME and I2C_LAST_FRAME,
thus we avoid using reload bit.
Reload suppose the next frame would be in the same direction,
but we have no guarranty about this. So we cannot use reload bit.
Note: in case of 2 consecutive I2C_FIRST_FRAME,
a restart is automatically generated only if there is direction change in the direction.
On last case #5 there was a last unexpected read.
It happened when stop condition was generated
- Removing LED pin definitions based on color.
- Removing and updating incorrect USB pin definitions.
- Adding comments for Arduino SPI and I2C pins.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170 0xc0170 removed request for a team August 28, 2019 19:15
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 28, 2019

CI restarted (crypto example was fixed)

@ciarmcom ciarmcom requested review from a team August 28, 2019 21:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal please review.

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170 0xc0170 removed request for a team August 29, 2019 04:32
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 29, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Aug 29, 2019
@0xc0170 0xc0170 merged commit 4531229 into ARMmbed:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants