Fix missing offset in TBStore read from flash #11296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could cause incomplete data retrieval and mismatch when reading data in more than one chunk, because every chunk would be read to the same location at the beginning of the output buffer.
|
@kyle-cypress, thank you for your changes. |
0xc0170
reviewed
Aug 26, 2019
This was caught when one of our team members temporarily set |
0xc0170
approved these changes
Aug 27, 2019
|
This PR is part of rollup PR #11366 Please do not update this PR, or if needed, let us know asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reading data from flash in more than one chunk, the current code reads every chunk to the same location in the output buffer. This change offset the read destination into the buffer by the current chunk's offset (similar to what is done for the CRC computation).
Submitting the pull request now to obtain feedback on the change. Greentea test logs will be attached soon.
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes