Dev i2c common code #3324

LMESTM · 2016-11-24T17:53:43Z

Description

This PR makes most of i2C_api.c into one common file.

This required some changes to align all the main I2C functions to HAL layer which is common between families. Also the PR contains a few HAL update that were required to have all families (except FA) to the same level of functionalities. F1 I2C driver will be moved in the same way, when the official support for sequential transmit and receive will be available in HAL.

By doing this common code, we can then get the I2C_ASYNCH featuer for all common families.
So the PR also enables ASYNCH for all STM32 (except F1 ones for now).

Status

READY

Test report:

bridadan · 2016-11-28T06:15:21Z

Changes look ok to me, I'll start the bots on this to make sure the build is OK. Do you have any test results or did you test out any of the I2C APIs manually?

Also @0xc0170, mind taking a look?

/morph test

bridadan · 2016-11-28T06:16:32Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-11-28T07:16:44Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1165

All builds and test passed!

LMESTM · 2016-11-28T08:01:34Z

@bridadan I enclosed the tests results below the description.
I2C master slave asynch (MBED_A29) was tested automatically.
then I did manual tests of synchronous APIs with the IKS01A1 board which makes use of I2C sensors.

bridadan · 2016-11-28T08:27:33Z

@LMESTM you're totally right about the test results, sorry about that. Currently suffering from some major jet lag, thanks for your patience 😄

LMESTM · 2016-11-28T08:46:28Z

@bridadan no pb ;-)

mbed-bot · 2016-11-28T09:38:43Z

[Build 1143]
FAILURE: Something went wrong when building and testing.

LMESTM · 2016-11-29T09:10:49Z

@bridadan Hi when it says something went wrong when building and testing : can you share what went wrong ?

0xc0170 · 2016-11-29T14:50:37Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-11-29T17:42:44Z

[Build 1147]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

bridadan · 2016-11-30T02:40:47Z

@LMESTM Not sure what the failure was, but looks like it is resolved now. Could you please address the merge conflict?

This is prelim update before official V1.8.0 HAL to the needed HAL API available as in F0 HAL which is using the same IP.

This is an alignement to F4 HAL as the same IP is used. Next official HAL delivery update hall will include the same alignement.

Applying the same fix as in L1 and F4

In case of sequential transmit / receive, there is a need to: - not use the reload option - generate a new START on each new transaction This applies to all HAL supporting the IP version V2.

Since most of the code in i2c_api.c is now relying on STM32 HAL, there is now a possibility to make a common usage of this code accross families. The IP version definition is introduced per family, to allow a switch of functionnalities, especially the frequency management which differs. BTw, we fix the F0 frequency settings at the same time. F1 is managed for now as an exception as the HAL API for sequential transmit /receive is not yet available (coming soon)

the I2C_ASYNCH feature is added to all STM32 except F1 family for now. Will be added when HAL update is done.

LMESTM · 2016-11-30T07:27:04Z

@bridadan I just rebased and conflicts are resolved

bridadan · 2016-12-01T01:53:44Z

Many thanks! @0xc0170 Could you review please? It'd be good to run the bots on this one more time before it comes in (due to the rebase).

LMESTM · 2016-12-01T13:49:59Z

@0xc0170 @bridadan
there has been an issue reported on MBED forum about the worng assert.
So I will actually add a basic commit change on top of this PR.

0xc0170 · 2016-12-01T14:03:10Z

targets/TARGET_STM/i2c_api.c

@@ -296,7 +296,7 @@ void i2c_frequency(i2c_t *obj, int hz)
    struct i2c_s *obj_s = I2C_S(obj);
    I2C_HandleTypeDef *handle = &(obj_s->handle);

-    MBED_ASSERT((hz > 0) && (hz <= 400000));
+    MBED_ASSERT((hz == 100000) || (hz == 400000) || (hz == 1000000));


Why is this so strict, only 3 values accepted?

Those are I2C supported frequencies
standard mode: 100 kbit/s, full speed: 400 kbit/s, fast mode: 1 mbit/s
Specific timings must be calculated for each frequency, and only timings for those values are implemented. Other requested frequencies may result in undefined behavior.

Looking again more closely: you actually have a point. My remark is only valid to I2C_IP_VERSION_V2 where timings must be hard coded. For I2C_IP_VERSION_V1 the HAL layer makes dynamic calculation and also make the checks - so I could move this ASSERT to I2C_IP_VERSION_V2 case only - Is it ok if I make the change now ?

So make the assert to cover all possible values Also assert applies only for I2C_IP_VERSION_V2. Also in case of I2C_IP_VERSION_V1, the HAL makes the proper checks and can dynamically scale the frequency in case of intermediate value.

LMESTM · 2016-12-05T08:04:41Z

@0xc0170 @bridadan
any further feedback or comments ?

LMESTM · 2016-12-06T14:31:14Z

ping ...

0xc0170 · 2016-12-06T14:51:57Z

/morph test

0xc0170 · 2016-12-06T14:54:56Z

LGTM ! Waiting for CI to complete

mbed-bot · 2016-12-06T15:32:55Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1206

Example Build failed!

LMESTM · 2016-12-07T07:44:05Z

@0xc0170 the morph test seems to report a failure but following the link I only see a PASS directory. Is there an error to look at ?

0xc0170 · 2016-12-07T12:51:04Z

@LMESTM looks to me failure with CI system, restarting it

/morph test

mbed-bot · 2016-12-07T16:52:18Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1215

All builds and test passed!

bridadan · 2016-12-08T17:36:30Z

That first failure was because some repos failed to clone, looks like the second one was OK.

…iginal cube HAL

Ports for Upcoming Targets 3241: Add support for FRDM-KW41 ARMmbed/mbed-os#3241 3291: Adding mbed enabled Maker board with NINA-B1 and EVA-M8Q ARMmbed/mbed-os#3291 Fixes and Changes 3062: TARGET_STM :USB device FS ARMmbed/mbed-os#3062 3213: STM32: Refactor us_ticker.c + hal_tick.c files ARMmbed/mbed-os#3213 3288: Dev spi asynch l0l1 ARMmbed/mbed-os#3288 3289: Bug fix of initial value of interrupt edge in "gpio_irq_init" function. ARMmbed/mbed-os#3289 3302: STM32F4 AnalogIn - Clear VBATE and TSVREFE bits before configuring ADC channels ARMmbed/mbed-os#3302 3320: STM32 - Add ADC_VREF label ARMmbed/mbed-os#3320 3321: no HSE available by default for NUCLEO_L432KC ARMmbed/mbed-os#3321 3352: ublox eva nina - fix line endings ARMmbed/mbed-os#3352 3322: DISCO_L053C8 doesn't support LSE ARMmbed/mbed-os#3322 3345: STM32 - Remove TIM_IT_UPDATE flag in HAL_Suspend/ResumeTick functions ARMmbed/mbed-os#3345 3309: [NUC472/M453] Fix CI failed tests ARMmbed/mbed-os#3309 3157: [Silicon Labs] Adding support for EFR32MG1 wireless SoC ARMmbed/mbed-os#3157 3301: I2C - correct return values for write functions (docs) - part 1 ARMmbed/mbed-os#3301 3303: Fix #2956 #2939 #2957 #2959 #2960: Add HAL_DeInit function in gpio_irq destructor ARMmbed/mbed-os#3303 3304: STM32L476: no HSE is present in NUCLEO and DISCO boards ARMmbed/mbed-os#3304 3318: Register map changes for RevG ARMmbed/mbed-os#3318 3317: NUCLEO_F429ZI has integrated LSE ARMmbed/mbed-os#3317 3312: K64F: SPI Asynch API implementation ARMmbed/mbed-os#3312 3324: Dev i2c common code ARMmbed/mbed-os#3324 3369: Add CAN2 missing pins for connector CN12 ARMmbed/mbed-os#3369 3377: STM32 NUCLEO-L152RE Update system core clock to 32MHz ARMmbed/mbed-os#3377 3378: K66F: Enable LWIP feature ARMmbed/mbed-os#3378 3382: [MAX32620] Fixing serial readable function. ARMmbed/mbed-os#3382 3399: NUCLEO_F103RB - Add SERIAL_FC feature ARMmbed/mbed-os#3399 3409: STM32L1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3409 3416: Renames i2c_api.c for STM32F1 targets to fix IAR exporter ARMmbed/mbed-os#3416 3348: Fix frequency function of CAN driver. ARMmbed/mbed-os#3348 3366: NUCLEO_F412ZG - Add new platform ARMmbed/mbed-os#3366 3379: STM32F0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3379 3393: ISR register never re-evaluated in HAL_DMA_PollForTransfer for STM32F4 ARMmbed/mbed-os#3393 3408: STM32F7 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3408 3411: STM32L0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3411 3424: STM32F4 - FIX to add the update of hdma->State variable ARMmbed/mbed-os#3424 3427: Fix stm i2c slave ARMmbed/mbed-os#3427 3429: Fix stm i2c fix init ARMmbed/mbed-os#3429 3434: [NUC472/M453] Fix stuck in lp_ticker_init and other updates ARMmbed/mbed-os#3434

bridadan approved these changes Nov 28, 2016

View reviewed changes

0xc0170 added the needs: CI label Nov 29, 2016

bridadan added needs: review and removed needs: CI labels Nov 30, 2016

LMESTM added 7 commits November 30, 2016 08:23

[STM32] HAL L0: I2C / DMA updates

77364f9

This is prelim update before official V1.8.0 HAL to the needed HAL API available as in F0 HAL which is using the same IP.

[STM32] HAL L1: I2C fix btf / rxne cases

85a2f7a

This is an alignement to F4 HAL as the same IP is used. Next official HAL delivery update hall will include the same alignement.

[STM32] HAL F2: I2C fix btf / rxne cases

a0722b1

Applying the same fix as in L1 and F4

[STM32] HAL I2C (V2) sequential transmit / receive

23926a2

In case of sequential transmit / receive, there is a need to: - not use the reload option - generate a new START on each new transaction This applies to all HAL supporting the IP version V2.

Add more supported boards to I2C master slave asynch test

014a48d

[STM32] enable I2C ASYNCH

0505a52

the I2C_ASYNCH feature is added to all STM32 except F1 family for now. Will be added when HAL update is done.

LMESTM force-pushed the dev_i2c_common_code branch from 7cc4934 to 0505a52 Compare November 30, 2016 07:26

0xc0170 reviewed Dec 1, 2016

View reviewed changes

STM32 I2C - 1MHZ frequency is allowed

29b32b8

So make the assert to cover all possible values Also assert applies only for I2C_IP_VERSION_V2. Also in case of I2C_IP_VERSION_V1, the HAL makes the proper checks and can dynamically scale the frequency in case of intermediate value.

LMESTM force-pushed the dev_i2c_common_code branch from 533763d to 29b32b8 Compare December 1, 2016 14:20

0xc0170 added needs: CI and removed needs: review labels Dec 6, 2016

0xc0170 added ready for merge and removed needs: CI labels Dec 7, 2016

0xc0170 added release-version: 5.3.1 and removed ready for merge labels Dec 9, 2016

0xc0170 merged commit 04f940d into ARMmbed:master Dec 9, 2016

bridadan mentioned this pull request Dec 9, 2016

Renames i2c_api.c for STM32F1 targets to fix IAR exporter #3416

Merged

3 tasks

ABOSTM added a commit to ABOSTM/mbed-os that referenced this pull request Aug 22, 2019

TARGET_STM: I2C sequential communication revert PR ARMmbed#3324 to or…

7647b39

…iginal cube HAL

ABOSTM mentioned this pull request Aug 26, 2019

I2 c sequential communication rework #11334

Merged

hugueskamba pushed a commit to evedon/mbed-os that referenced this pull request Aug 29, 2019

TARGET_STM: I2C sequential communication revert PR ARMmbed#3324 to or…

e9fcb21

…iginal cube HAL

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev i2c common code #3324

Dev i2c common code #3324

LMESTM commented Nov 24, 2016 •

edited

Loading

bridadan commented Nov 28, 2016

bridadan commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

LMESTM commented Nov 28, 2016

bridadan commented Nov 28, 2016

LMESTM commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

LMESTM commented Nov 29, 2016

0xc0170 commented Nov 29, 2016

mbed-bot commented Nov 29, 2016

bridadan commented Nov 30, 2016

LMESTM commented Nov 30, 2016

bridadan commented Dec 1, 2016

LMESTM commented Dec 1, 2016

0xc0170 Dec 1, 2016

LMESTM Dec 1, 2016

LMESTM Dec 1, 2016

LMESTM commented Dec 5, 2016

LMESTM commented Dec 6, 2016

0xc0170 commented Dec 6, 2016

0xc0170 commented Dec 6, 2016

mbed-bot commented Dec 6, 2016

LMESTM commented Dec 7, 2016

0xc0170 commented Dec 7, 2016

mbed-bot commented Dec 7, 2016

bridadan commented Dec 8, 2016

Dev i2c common code #3324

Dev i2c common code #3324

Conversation

LMESTM commented Nov 24, 2016 • edited Loading

Description

Status

bridadan commented Nov 28, 2016

bridadan commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

Result: SUCCESS

Output

LMESTM commented Nov 28, 2016

bridadan commented Nov 28, 2016

LMESTM commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

LMESTM commented Nov 29, 2016

0xc0170 commented Nov 29, 2016

mbed-bot commented Nov 29, 2016

bridadan commented Nov 30, 2016

LMESTM commented Nov 30, 2016

bridadan commented Dec 1, 2016

LMESTM commented Dec 1, 2016

0xc0170 Dec 1, 2016

Choose a reason for hiding this comment

LMESTM Dec 1, 2016

Choose a reason for hiding this comment

LMESTM Dec 1, 2016

Choose a reason for hiding this comment

LMESTM commented Dec 5, 2016

LMESTM commented Dec 6, 2016

0xc0170 commented Dec 6, 2016

0xc0170 commented Dec 6, 2016

mbed-bot commented Dec 6, 2016

Result: FAILURE

Output

LMESTM commented Dec 7, 2016

0xc0170 commented Dec 7, 2016

mbed-bot commented Dec 7, 2016

Result: SUCCESS

Output

bridadan commented Dec 8, 2016

LMESTM commented Nov 24, 2016 •

edited

Loading