Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32F0 : map ST HAL assert into MBED assert #3379

Merged
merged 2 commits into from
Dec 15, 2016
Merged

STM32F0 : map ST HAL assert into MBED assert #3379

merged 2 commits into from
Dec 15, 2016

Conversation

jeromecoutant
Copy link
Collaborator

Description

ST HAL assert is mapped onto MBED HAL assert, and can now be enabled easily.

Note for all STM32 targets:

  • ST asserts are used to check each parameters in ST HAL function call
  • They are not compiled by default, you have to define USE_FULL_ASSERT to enable them

Test

OS2 and OS5 tests done.
Few updates have been needed to match ST HAL API.

Status

READY

0xc0170
0xc0170 requested changes Dec 7, 2016
View reviewed changes
targets/TARGET_STM/TARGET_STM32F0/TARGET_NUCLEO_F042K6/device/stm32f042x6.h
@@ -10274,7 +10274,7 @@ typedef struct
#define IS_ADC_COMMON_INSTANCE(INSTANCE) ((INSTANCE) == ADC)

/******************************* CAN Instances ********************************/
#define IS_CAN_ALL_INSTANCE(INSTANCE) ((INSTANCE) == CAN)
#define IS_CAN_ALL_INSTANCE(INSTANCE) ((INSTANCE) == CAN1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes that are not related to the changeset in the commit message (assert). Please split this commit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2016

Thanks fro splitting ! However the second commit says its ST HAL assert , and changes are CAN, gpio and ADC changes (flag changes for peripherals) that might not be common ? I dont know why these changes are required.

@jeromecoutant
Copy link
Collaborator Author

Code I have updated is not compiled, or is compiled only if we enable the ST assert.
During my tests, I enabled assert and had to clean few lines in files in order to make all tests OK.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2016 •
edited
Loading

Code I have updated is not compiled, or is compiled only if we enable the ST assert.
During my tests, I enabled assert and had to clean few lines in files in order to make all tests OK.

Thanks for the explanation. It's not clear from the code. I would say that ADC change is not only for assert()?

LGTM as it is just please consider providing more details to the second commit message. It's not clear what it does to me at least. Same shall be then applied to other PR that contain the same commit message with similar changes.

@jeromecoutant
STM32F0 : correct ST HAL API call
6aef533 
- CAN: compilation issue with assert enabled
- ADC: init parameter was not allowed by ST HAL API
- GPIO: mode was not allowed by ST HAL API
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Dec 9, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1242

All builds and test passed!

@sg- sg- merged commit 0a40444 into ARMmbed:master Dec 15, 2016
@jeromecoutant jeromecoutant deleted the PR_ST_F0_ASSERT branch January 23, 2017 09:42
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 132 of the mbed library
12c3a2c 
Ports for Upcoming Targets

3241: Add support for FRDM-KW41 ARMmbed/mbed-os#3241
3291: Adding mbed enabled Maker board with NINA-B1 and EVA-M8Q ARMmbed/mbed-os#3291

Fixes and Changes

3062: TARGET_STM :USB device FS  ARMmbed/mbed-os#3062
3213: STM32: Refactor us_ticker.c + hal_tick.c files ARMmbed/mbed-os#3213
3288: Dev spi asynch l0l1 ARMmbed/mbed-os#3288
3289: Bug fix of initial value of interrupt edge in "gpio_irq_init" function. ARMmbed/mbed-os#3289
3302: STM32F4 AnalogIn - Clear VBATE and TSVREFE bits before configuring ADC channels ARMmbed/mbed-os#3302
3320: STM32 - Add ADC_VREF label ARMmbed/mbed-os#3320
3321: no HSE available by default for NUCLEO_L432KC ARMmbed/mbed-os#3321
3352: ublox eva nina - fix line endings ARMmbed/mbed-os#3352
3322: DISCO_L053C8 doesn't support LSE ARMmbed/mbed-os#3322
3345: STM32 - Remove TIM_IT_UPDATE flag in HAL_Suspend/ResumeTick functions ARMmbed/mbed-os#3345
3309: [NUC472/M453] Fix CI failed tests ARMmbed/mbed-os#3309
3157: [Silicon Labs] Adding support for EFR32MG1 wireless SoC ARMmbed/mbed-os#3157
3301: I2C - correct return values for write functions (docs) - part 1 ARMmbed/mbed-os#3301
3303: Fix #2956 #2939 #2957 #2959 #2960: Add HAL_DeInit function in gpio_irq destructor ARMmbed/mbed-os#3303
3304: STM32L476: no HSE is present in NUCLEO and DISCO boards ARMmbed/mbed-os#3304
3318: Register map changes for RevG ARMmbed/mbed-os#3318
3317: NUCLEO_F429ZI has integrated LSE ARMmbed/mbed-os#3317
3312: K64F: SPI Asynch API implementation ARMmbed/mbed-os#3312
3324: Dev i2c common code ARMmbed/mbed-os#3324
3369: Add CAN2 missing pins for connector CN12 ARMmbed/mbed-os#3369
3377: STM32 NUCLEO-L152RE Update system core clock to 32MHz ARMmbed/mbed-os#3377
3378: K66F: Enable LWIP feature ARMmbed/mbed-os#3378
3382: [MAX32620] Fixing serial readable function. ARMmbed/mbed-os#3382
3399: NUCLEO_F103RB - Add SERIAL_FC feature ARMmbed/mbed-os#3399
3409: STM32L1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3409
3416: Renames i2c_api.c for STM32F1 targets to fix IAR exporter ARMmbed/mbed-os#3416
3348: Fix frequency function of CAN driver. ARMmbed/mbed-os#3348
3366: NUCLEO_F412ZG - Add new platform ARMmbed/mbed-os#3366
3379: STM32F0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3379
3393: ISR register never re-evaluated in HAL_DMA_PollForTransfer for STM32F4 ARMmbed/mbed-os#3393
3408: STM32F7 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3408
3411: STM32L0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3411
3424: STM32F4 - FIX to add the update of hdma->State variable ARMmbed/mbed-os#3424
3427: Fix stm i2c slave ARMmbed/mbed-os#3427
3429: Fix stm i2c fix init ARMmbed/mbed-os#3429
3434: [NUC472/M453] Fix stuck in lp_ticker_init and other updates ARMmbed/mbed-os#3434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridadan bridadan bridadan approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @0xc0170 @mbed-bot @bridadan @sg-