-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repair deterministic playback #174
Conversation
Thanks for the quick repair. @zhuyifengzju should test this PR as well. |
Shall we close PR #167 given this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested localy, and this PR fixed the issue. And I think the #167 is also resolved in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this assertion too harsh? Maybe we should allow for some tolerance for small numerical errors in checking the state matching.
assert(np.all(np.equal(states[j + 1], state_playback))) |
Also, tried the replay function with one demonstration collected with the keyboard (download this demonstration file) and this assertion throws exception.
value
#162