Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair deterministic playback #174

Merged
merged 4 commits into from
Jan 15, 2021
Merged

repair deterministic playback #174

merged 4 commits into from
Jan 15, 2021

Conversation

amandlek
Copy link
Member

@amandlek amandlek commented Jan 14, 2021

@yukezhu
Copy link
Member

yukezhu commented Jan 14, 2021

Thanks for the quick repair. @zhuyifengzju should test this PR as well.

@yukezhu
Copy link
Member

yukezhu commented Jan 14, 2021

Shall we close PR #167 given this one?

@yukezhu yukezhu requested a review from zhuyifengzju January 14, 2021 18:47
Copy link
Contributor

@zhuyifengzju zhuyifengzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested localy, and this PR fixed the issue. And I think the #167 is also resolved in this PR.

Copy link
Member

@yukezhu yukezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this assertion too harsh? Maybe we should allow for some tolerance for small numerical errors in checking the state matching.

assert(np.all(np.equal(states[j + 1], state_playback)))

Also, tried the replay function with one demonstration collected with the keyboard (download this demonstration file) and this assertion throws exception.

@amandlek amandlek mentioned this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants