Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-ESM1.5 mppnccombine MPI Test Fix #47

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Aug 13, 2024

See https://github.com/ACCESS-NRI/access-esm1.5-configs/pull/44/checks?check_run_id=28688143378

We allow collate.mpi to be either true or false, rather than only true.

Since converting the .yaml file into a Python dict also converts the above to a bool, test that the resulting value is an instance of bool.

In this PR:

  • Update the test
  • Update the version of model-config-tests to 0.0.7

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (f2f37d9) to head (2d538a5).
Report is 1 commits behind head on main.

Files Patch % Lines
...model_config_tests/qa/test_access_esm1p5_config.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files          15       15           
  Lines         724      724           
=======================================
  Hits          532      532           
  Misses        192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in-person.

@CodeGat CodeGat merged commit 0649090 into main Aug 13, 2024
7 of 8 checks passed
@CodeGat CodeGat deleted the access-esm1p5-mppnccombine-mpi-fix branch August 13, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants