Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACCESS-ESM1.5 mppnccombine MPI Test Fix #47

Merged
merged 2 commits into from
Aug 13, 2024
Merged

ACCESS-ESM1.5 mppnccombine MPI Test Fix #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec2b080
Updated the `collate.mpi` value assertion
CodeGat Aug 13, 2024
2d538a5
Updated version to `0.0.7`
CodeGat Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "model_config_tests"
version = "0.0.6"
version = "0.0.7"
authors = [
{ name = "ACCESS-NRI" },
]
Expand Down
7 changes: 5 additions & 2 deletions src/model_config_tests/qa/test_access_esm1p5_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@
"collate.mpi", "config.yaml"
)

assert config["collate"]["mpi"], error_field_incorrect(
"collate.mpi", "config.yaml", "true"
# Loading the yaml into a dict also converts
# `collate.mpi:true`/`collate.mpi:false` to `True`/`False` so we
# can assert if it is a `bool`.
assert isinstance(config["collate"]["mpi"], bool), error_field_incorrect(

Check warning on line 191 in src/model_config_tests/qa/test_access_esm1p5_config.py

View check run for this annotation

Codecov / codecov/patch

src/model_config_tests/qa/test_access_esm1p5_config.py#L191 

Added line #L191 was not covered by tests
"collate.mpi", "config.yaml", "true or false"
)
Loading