Pre-industrial: remove reference to deleted parexe file #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blimlim
changed the base branch from
pre-industrial
to
dev-preindustrial+concentrations
aidanheerdegen
requested changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42 removed the unused
parexefile from the pre-industrial configuration's atmosphere directory. References to this deleted can then be removed from theum_env.yamlfile. Note that thePAREXEsetting cannot be removed entirely due tohttps://github.com/ACCESS-NRI/UM_v7/blob/dc55b04ac66ee008719c765bc11999d91f1c15cb/umbase_hg3/src/control/top_level/um_shell.F90#L317-L324
However we can at lest set this parameter to nothing, which is done in this pull request.
Also changed the target of this PR to the
dev-preindustrial+concentrationsbranch, which required the addition of files to make the QA checks pass.