Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #38

Merged
merged 28 commits into from
Nov 19, 2024
Merged

Develop #38

merged 28 commits into from
Nov 19, 2024

Conversation

HyunWoo9930
Copy link
Collaborator

@HyunWoo9930 HyunWoo9930 commented Nov 19, 2024

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [feat] PR을 λ“±λ‘ν•œλ‹€.
  • πŸ’― ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • πŸ—οΈ λΉŒλ“œλŠ” μ„±κ³΅ν–ˆλ‚˜μš”?
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?
  • πŸ’­ μ΄μŠˆλŠ” λ“±λ‘ν–ˆλ‚˜μš”?
  • 🏷️ 라벨은 λ“±λ‘ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μš©

μ£Όμ˜μ‚¬ν•­

Summary by CodeRabbit

릴리슀 λ…ΈνŠΈ

  • μ‹ κ·œ κΈ°λŠ₯

    • Java μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ˜ CI/CDλ₯Ό μœ„ν•œ GitHub Actions μ›Œν¬ν”Œλ‘œμš° μΆ”κ°€.
    • μŠ€ν† μ–΄ 검색 및 결제 κ·Έλ£Ή 관리 κΈ°λŠ₯ μΆ”κ°€.
    • νŒ€ κ°€μž… κΈ°λŠ₯ μΆ”κ°€ 및 κ΄€λ ¨ μ—”λ“œν¬μΈνŠΈ κ΅¬ν˜„.
  • 버그 μˆ˜μ •

    • μŠ€ν† μ–΄ 및 νŒ€ κ΄€λ ¨ μ˜ˆμ™Έ 처리 κ°œμ„ .
  • λ¬Έμ„œν™”

    • μƒˆλ‘œμš΄ 데이터 전솑 객체 및 응닡 클래슀 μΆ”κ°€.
  • λ¦¬νŒ©ν† λ§

    • λ©”μ„œλ“œ 이름 및 μ„œλͺ… 일관성 κ°œμ„ .

LEEJaeHyeok97 and others added 28 commits November 18, 2024 20:59
feat: 결제 κΈ°λŠ₯ μš”κ΅¬μ‚¬ν•­ 반영
* feat: Team 도메인 μˆ˜μ • 및 일급 μ»¬λ ‰μ…˜ν™”

* feat: νŒ€ 생성 κΈ°λŠ₯ κ΅¬ν˜„
feat: team κ°€μž… κΈ°λŠ₯ κ΅¬ν˜„
feat: team κ°€μž… κΈ°λŠ₯ κ΅¬ν˜„
feat: μΉ΄ν…Œκ³ λ¦¬ 별 κ°€κ²Œ λͺ©λ‘ 쑰회 κ΅¬ν˜„
feat: μΉ΄ν…Œκ³ λ¦¬ 별 κ°€κ²Œ λͺ©λ‘ 쑰회 κ΅¬ν˜„
Copy link

coderabbitai bot commented Nov 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이 λ³€κ²½ 사항은 Java μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ˜ 지속적 톡합 및 배포λ₯Ό μœ„ν•œ μƒˆλ‘œμš΄ GitHub Actions μ›Œν¬ν”Œλ‘œ 파일 deploy.yml을 λ„μž…ν•©λ‹ˆλ‹€. 이 μ›Œν¬ν”Œλ‘œλŠ” develop λΈŒλžœμΉ˜μ— ν‘Έμ‹œλ  λ•Œ 트리거되며, Docker 이미지λ₯Ό λΉŒλ“œν•˜κ³  EC2 μΈμŠ€ν„΄μŠ€μ—μ„œ μ‹€ν–‰ν•˜λŠ” 두 가지 μ£Όμš” μž‘μ—…μœΌλ‘œ κ΅¬μ„±λ©λ‹ˆλ‹€. λ˜ν•œ, μ—¬λŸ¬ Java ν΄λž˜μŠ€μ™€ λ ˆμ½”λ“œκ°€ μˆ˜μ •λ˜κ±°λ‚˜ μΆ”κ°€λ˜μ–΄ 결제 처리 및 νŒ€ 관리 κΈ°λŠ₯을 ν–₯μƒμ‹œν‚΅λ‹ˆλ‹€.

Changes

파일 경둜 λ³€κ²½ μš”μ•½
.github/workflows/deploy.yml μƒˆλ‘œμš΄ GitHub Actions μ›Œν¬ν”Œλ‘œ μΆ”κ°€: Java CI with Gradle, Docker 이미지 λΉŒλ“œ 및 EC2μ—μ„œ μ‹€ν–‰ν•˜λŠ” μž‘μ—… 포함.
Dockerfile Java μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ„ μœ„ν•œ Dockerfile μΆ”κ°€, OpenJDK 21을 기반으둜 μ„€μ •.
src/main/java/com/jangburich/domain/payment/application/KakaopayService.java StoreNotFoundException μΆ”κ°€, payReady 및 payApprove λ©”μ„œλ“œ μˆ˜μ •μœΌλ‘œ 결제 처리 둜직 ν–₯상.
src/main/java/com/jangburich/domain/payment/application/PaymentProcessingService.java 파일 끝의 곡백 제거.
src/main/java/com/jangburich/domain/payment/domain/TeamChargeHistory.java Storeμ™€μ˜ 관계λ₯Ό λ‚˜νƒ€λ‚΄λŠ” μƒˆλ‘œμš΄ ν•„λ“œ μΆ”κ°€, μƒμ„±μž μˆ˜μ •.
src/main/java/com/jangburich/domain/payment/domain/TeamChargeHistoryResponse.java μƒˆλ‘œμš΄ λ ˆμ½”λ“œ TeamChargeHistoryResponse μΆ”κ°€.
src/main/java/com/jangburich/domain/payment/domain/repository/TeamChargeHistoryRepository.java μƒˆλ‘œμš΄ λ©”μ„œλ“œ findAllByTeam 및 findAllByStore μΆ”κ°€.
src/main/java/com/jangburich/domain/payment/dto/request/PayRequest.java 파일 끝의 곡백 μΆ”κ°€.
src/main/java/com/jangburich/domain/payment/presentation/PaymentController.java λ©”μ„œλ“œ ν¬λ§·νŒ… μ‘°μ •.
src/main/java/com/jangburich/domain/store/domain/StoreChargeHistoryResponse.java μƒˆλ‘œμš΄ λ ˆμ½”λ“œ StoreChargeHistoryResponse μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/StoreTeam.java μƒˆλ‘œμš΄ ν•„λ“œ remainPoint μΆ”κ°€, λ©”μ„œλ“œ 이름 λ³€κ²½ 및 μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/StoreTeamResponseDTO.java μƒˆλ‘œμš΄ λ ˆμ½”λ“œ StoreTeamResponseDTO μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/controller/StoreController.java μ—¬λŸ¬ μƒˆλ‘œμš΄ λ©”μ„œλ“œ μΆ”κ°€ 및 κΈ°μ‘΄ λ©”μ„œλ“œ 이름 μ‘°μ •.
src/main/java/com/jangburich/domain/store/domain/dto/condition/StoreSearchCondition.java μƒˆλ‘œμš΄ λ ˆμ½”λ“œ StoreSearchCondition μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/dto/condition/StoreSearchConditionWithType.java μƒˆλ‘œμš΄ λ ˆμ½”λ“œ StoreSearchConditionWithType μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/dto/response/PaymentGroupDetailResponse.java μƒˆλ‘œμš΄ 클래슀 PaymentGroupDetailResponse μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/dto/response/SearchStoresResponse.java μƒˆλ‘œμš΄ λ ˆμ½”λ“œ SearchStoresResponse μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/repository/StoreQueryDslRepository.java μƒˆλ‘œμš΄ μΈν„°νŽ˜μ΄μŠ€ StoreQueryDslRepository μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/repository/StoreQueryDslRepositoryImpl.java StoreQueryDslRepository μΈν„°νŽ˜μ΄μŠ€ κ΅¬ν˜„.
src/main/java/com/jangburich/domain/store/domain/repository/StoreRepository.java StoreQueryDslRepository μΈν„°νŽ˜μ΄μŠ€ ν™•μž₯.
src/main/java/com/jangburich/domain/store/domain/repository/StoreTeamRepository.java μƒˆλ‘œμš΄ λ©”μ„œλ“œ findAllByStore μΆ”κ°€.
src/main/java/com/jangburich/domain/store/domain/service/StoreService.java μ—¬λŸ¬ μƒˆλ‘œμš΄ λ©”μ„œλ“œ μΆ”κ°€ 및 κΈ°μ‘΄ λ©”μ„œλ“œ 이름 μ‘°μ •.
src/main/java/com/jangburich/domain/store/exception/ResourceNotFoundException.java μƒˆλ‘œμš΄ μ˜ˆμ™Έ 클래슀 ResourceNotFoundException μΆ”κ°€.
src/main/java/com/jangburich/domain/store/exception/StoreNotFoundException.java μƒˆλ‘œμš΄ μ˜ˆμ™Έ 클래슀 StoreNotFoundException μΆ”κ°€.
src/main/java/com/jangburich/domain/team/application/TeamService.java μƒˆλ‘œμš΄ λ©”μ„œλ“œ joinTeam μΆ”κ°€ 및 registerTeam λ©”μ„œλ“œ μˆ˜μ •.
src/main/java/com/jangburich/domain/team/domain/Team.java μƒˆλ‘œμš΄ ν•„λ“œ point μΆ”κ°€ 및 μ—¬λŸ¬ λ©”μ„œλ“œ μΆ”κ°€.
src/main/java/com/jangburich/domain/team/domain/repository/TeamRepository.java μƒˆλ‘œμš΄ λ©”μ„œλ“œ findBySecretCode μΆ”κ°€.
src/main/java/com/jangburich/domain/team/domain/repository/UserTeamRepository.java μƒˆλ‘œμš΄ λ©”μ„œλ“œ countByTeam 및 existsByUserAndTeam μΆ”κ°€.
src/main/java/com/jangburich/domain/team/presentation/TeamController.java μƒˆλ‘œμš΄ λ©”μ„œλ“œ joinTeam μΆ”κ°€.

Possibly related PRs

  • DevelopΒ #36: KakaopayService 클래슀의 λ³€κ²½ 사항은 결제 μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ˜ 배포와 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.

🐰 λ³€ν™”μ˜ λ°”λžŒμ΄ λΆˆμ–΄μ˜€κ³ ,
μƒˆλ‘œμš΄ κΈ°λŠ₯이 가득 차였λ₯΄λ„€.
νŒ€κ³Ό κ°€κ²Œκ°€ ν•¨κ»˜ μΆ€μΆ”λ©°,
결제의 길이 λ”μš± 밝아지넀.
Rabbit's joy in every line,
μ½”λ“œ 속에 μˆ¨κ²¨μ§„ μ‹ λΉ„λ₯Ό μ°Ύμ•„! πŸ‡βœ¨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@HyunWoo9930 HyunWoo9930 merged commit 6e8d728 into main Nov 19, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants