Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 카테고리 별 가게 목록 조회 구현 #34

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

LEEJaeHyeok97
Copy link
Member

@LEEJaeHyeok97 LEEJaeHyeok97 commented Nov 18, 2024

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

작업 내용

주의사항

Summary by CodeRabbit

  • 신규 기능
    • 카테고리 및 검색 기준에 따라 매장 목록을 검색할 수 있는 새로운 GET 엔드포인트 추가.
    • 매장 정보 조회 시 매장 ID를 경로 변수로 요구하도록 변경.
  • 버그 수정
    • 사용자 인증을 통한 검색 기능 개선.
  • 문서화
    • 새로운 예외 클래스 ResourceNotFoundException 추가.

Copy link

coderabbitai bot commented Nov 18, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

StoreController 클래스에 새로운 메서드가 추가되고 기존 메서드의 시그니처가 변경되었습니다. 새로운 GET 엔드포인트인 searchByCategorysearchStores가 도입되어 사용자가 카테고리 및 검색 기준에 따라 상점 목록을 검색할 수 있게 되었습니다. 또한 getStoreInfo 메서드는 storeId를 경로 변수로 요구하도록 수정되었습니다. 새로운 레코드 클래스들이 추가되어 검색 조건 및 응답 구조를 정의하고, StoreQueryDslRepository 인터페이스와 그 구현체가 추가되어 쿼리 기능이 확장되었습니다.

Changes

파일 경로 변경 요약
src/main/java/com/jangburich/domain/store/domain/controller/StoreController.java 새로운 메서드 searchByCategory, searchStores 추가; getStoreInfo 메서드 시그니처 변경.
src/main/java/com/jangburich/domain/store/domain/dto/condition/StoreSearchCondition.java 새로운 레코드 클래스 StoreSearchCondition 추가 (위도, 경도 포함).
src/main/java/com/jangburich/domain/store/domain/dto/condition/StoreSearchConditionWithType.java 새로운 레코드 클래스 StoreSearchConditionWithType 추가 (Boolean 필드 포함).
src/main/java/com/jangburich/domain/store/domain/dto/response/SearchStoresResponse.java 새로운 레코드 클래스 SearchStoresResponse 추가 (상점 검색 응답 데이터 포함).
src/main/java/com/jangburich/domain/store/domain/repository/StoreQueryDslRepository.java 새로운 인터페이스 StoreQueryDslRepository 추가; 메서드 findStoresByCategory, findStores 추가.
src/main/java/com/jangburich/domain/store/domain/repository/StoreQueryDslRepositoryImpl.java StoreQueryDslRepository 구현체 추가; 쿼리 메서드 구현.
src/main/java/com/jangburich/domain/store/domain/repository/StoreRepository.java StoreQueryDslRepository 인터페이스를 확장하도록 수정.
src/main/java/com/jangburich/domain/store/domain/service/StoreService.java 새로운 메서드 searchByCategory, searchStores 추가.
src/main/java/com/jangburich/domain/store/exception/ResourceNotFoundException.java 새로운 예외 클래스 ResourceNotFoundException 추가.

Possibly related PRs

  • Develop #23: StoreControllergetStoreInfo 메서드 시그니처 변경과 관련이 있으며, 이전 PR에서도 동일한 메서드에서 storeId 매개변수를 제거하는 수정이 있었습니다.

🐰 변화의 춤을 추며,
상점 찾는 길을 열어,
카테고리와 키워드로,
모두가 함께 찾아보아요.
새로운 레코드와 쿼리로,
더 나은 서비스가 시작되니,
기쁜 마음으로 뛰어가요! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LEEJaeHyeok97 LEEJaeHyeok97 merged commit ac83537 into main Nov 18, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant