-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2454179629
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@francovenica please test with L2 Safes as well as with 1.1.1+Circles Safes.
@francovenica this PR is top priority when you're back. We need this for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me.
I created a new safe in the GNO chain. I tried to add a new owner I tried the same in prod and it worked fine Safe in this PR In Prod: |
This sounds a lot like indexing issues. Can you create/execute transactions on other gno Safes? |
Ok, I had no problem in 1.3.0+L2 safes. Tested in GNO chain, Poly, BSC, Arbitrum, Avalanche. We still have to confirm that this work for "Circles safes". |
What it solves
Reverts #3891 changes
How this PR fixes it
Version metadata is now handled by
safe-deployments
and we can therefore remove this hotfix.How to test it
Any process involved the mastercopy of L2/Circles Safes should be tested; executing a transaction, upgrading the Safe, etc.