Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: remove +L2 hotfix #3934

Merged
merged 4 commits into from
Jun 9, 2022
Merged

fix: remove +L2 hotfix #3934

merged 4 commits into from
Jun 9, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jun 7, 2022

What it solves

Reverts #3891 changes

How this PR fixes it

Version metadata is now handled by safe-deployments and we can therefore remove this hotfix.

How to test it

Any process involved the mastercopy of L2/Circles Safes should be tested; executing a transaction, upgrading the Safe, etc.

@iamacook iamacook self-assigned this Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Deployment links

Mainnet     🟣 Polygon     🟠 Rinkeby

@coveralls
Copy link

coveralls commented Jun 7, 2022

Pull Request Test Coverage Report for Build 2454179629

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 36.903%

Totals Coverage Status
Change from base Build 2453146547: 0.008%
Covered Lines: 3896
Relevant Lines: 9589

💛 - Coveralls

@iamacook iamacook changed the title WIP: fix: remove +L2 hotfix fix: remove +L2 hotfix Jun 7, 2022
@iamacook iamacook requested a review from katspaugh June 7, 2022 11:27
@iamacook iamacook marked this pull request as ready for review June 7, 2022 11:27
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@francovenica please test with L2 Safes as well as with 1.1.1+Circles Safes.

@katspaugh
Copy link
Member

@francovenica this PR is top priority when you're back. We need this for the release.

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

@francovenica
Copy link
Contributor

I created a new safe in the GNO chain. I tried to add a new owner
The tx got stuck in the "pending" status and never came out of it, never showed in history, and the owner doesn't show in the owners list, despite the tx being confirmed in the block explorer just fine.

I tried the same in prod and it worked fine

Safe in this PR
https://pr3934--safereact.review-safe.gnosisdev.com/app/gno:0xBe7389E497EA0372c48d7048A58d024F0997f608/settings/owners
The tx in the block explorer
https://blockscout.com/xdai/mainnet/tx/0x88b450b97521bf906488cd3311f9443b98f6abf9f8f2768901e9a7ca620edef6

In Prod:
https://gnosis-safe.io/app/gno:0xA4605e4cF3575Dfc93eD593c17B136C3A4F32844/transactions/history
https://blockscout.com/xdai/mainnet/tx/0xe8b86963c20d88fad53dc4d176514ae26960295f9e164e9474b9988c14d60452

@iamacook
Copy link
Member Author

iamacook commented Jun 8, 2022

I created a new safe in the GNO chain. I tried to add a new owner The tx got stuck in the "pending" status and never came out of it, never showed in history, and the owner doesn't show in the owners list, despite the tx being confirmed in the block explorer just fine.

This sounds a lot like indexing issues. Can you create/execute transactions on other gno Safes?

@francovenica
Copy link
Contributor

Ok, I had no problem in 1.3.0+L2 safes. Tested in GNO chain, Poly, BSC, Arbitrum, Avalanche.
Also tried a GNO safe that is just 1.3.0 and tx work fine as well.

We still have to confirm that this work for "Circles safes".
@liliya-soroka @JagoFigueroa since you guys start the day earlier than me, if you finally get the safe the test give it a try.

@iamacook iamacook merged commit f5696a4 into dev Jun 9, 2022
@iamacook iamacook deleted the remove-l2-hotfix branch June 9, 2022 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants