Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Load safe form - Safe validation with unsupported mastercopies #3923

Closed
francovenica opened this issue May 27, 2022 · 2 comments
Closed

Load safe form - Safe validation with unsupported mastercopies #3923

francovenica opened this issue May 27, 2022 · 2 comments
Assignees
Labels
Bug 🐛 Something isn't working

Comments

@francovenica
Copy link
Contributor

francovenica commented May 27, 2022

Description

In the 2nd step of the load safe form the address input validates if the safe is ok to be loaded into the app.
We found a specific safe that seems to have been created in a different fork of the web app for the BSC network. This safe was not created with an unsupported master copy
The address: 0xDF951b3657777ee21a3B01494C362d2ea9d4378E
Full data: https://safe-client.gnosis.io/v1/chains/56/safes/0xDF951b3657777ee21a3B01494C362d2ea9d4378E

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: BSC
  • Env: Prod

Steps to reproduce

  1. Go to the gnosis safe and go the load form
  2. Change to the BSC network
  3. In the address paste this value: 0xDF951b3657777ee21a3B01494C362d2ea9d4378E. The address is validated by the input
  4. Try to finish the form

Expected result

The input should not validate this safe in particular. It should show an error indicating the safe has an unsupported MC

Obtained result

You can go all the way to the last step where you find a console error

Screenshots

The console Error:
image

The type of message expected:
image

@francovenica francovenica added the Bug 🐛 Something isn't working label May 27, 2022
@francovenica francovenica moved this to Todo in Web Squad May 27, 2022
@5afe 5afe deleted a comment May 28, 2022
@DiogoSoaress DiogoSoaress moved this from Todo to In Progress in Web Squad Jun 8, 2022
@DiogoSoaress DiogoSoaress self-assigned this Jun 8, 2022
@DiogoSoaress
Copy link
Member

You can go all the way to the last step where you find a console error

@francovenica with the PR https://github.com/safe-global/safe-react/pull/3934/files that is about to be merged, there is no console log anymore.

We found a specific safe that seems to have been created in a different fork of the web app for the BSC network. This safe was not created with an unsupported master copy

Regarding loading the Safe created with a wrong Mastercopy, we have this PR #3908 where we display info in that regard.

My question to you is if it makes sense to validate the Safe address in the Step 2 of the Load Safe flow ?

cc @johannesmoormann @katspaugh

@francovenica
Copy link
Contributor Author

Tickets #3908 and #3934 will solve this issue.

Closing this one

Repository owner moved this from In Progress to Done in Web Squad Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants