Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: remove +L2 suffix from currentVersion #3891

Merged
merged 2 commits into from
May 18, 2022
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves retrieval of contract ABIs

How this PR fixes it

The currentVersion -+L2 suffix is removed before saving to the store.

How to test it

Open a Safe on an L2 network and create/execute a transaction. There should be no Code 815: Error preparing transaction sender warning in the console preventing you from executing the transaction.

Note

This needs to be revisited with a cleaner fix.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@iamacook iamacook requested a review from katspaugh May 18, 2022 15:55
@github-actions
Copy link

github-actions bot commented May 18, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

schmanu
schmanu previously approved these changes May 18, 2022
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the quick hotfix. 🥇

I think omitting the L2 is fine as we find out which chain is L2 from our chainConfigs / ChainInfo.

@iamacook
Copy link
Member Author

ty for the quick hotfix. 🥇

I think omitting the L2 is fine as we find out which chain is L2 from our chainConfigs / ChainInfo.

There's definitely a more elegant approach, perhaps via the selector but let's discuss it tomorrow.

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Uxio0
Uxio0 previously approved these changes May 18, 2022
katspaugh
katspaugh previously approved these changes May 18, 2022
@katspaugh katspaugh changed the base branch from dev to main May 18, 2022 16:20
@katspaugh katspaugh dismissed stale reviews from Uxio0, schmanu, and themself May 18, 2022 16:20

The base branch was changed.

@katspaugh katspaugh changed the base branch from main to release/3.25.3 May 18, 2022 16:23
@katspaugh katspaugh merged commit 7a6792a into release/3.25.3 May 18, 2022
@katspaugh katspaugh deleted the remove-suffix branch May 18, 2022 16:23
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants