Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Notifications Improvements #135

Closed
lukasschor opened this issue Jul 17, 2019 · 3 comments
Closed

Notifications Improvements #135

lukasschor opened this issue Jul 17, 2019 · 3 comments
Assignees
Labels
Major Needs to be fixed for immediate next public release.

Comments

@lukasschor
Copy link
Member

lukasschor commented Jul 17, 2019

Notification at the top

Currently, all notifications pop up on the bottom right of the screen. User tests have shown that users would expect the notification to be at the top for increased visibility. Display notifications below the header.

Sticky Notifications

Sticky notifications if the status does not change. E.g. show the "Rinkeby warning" notification (#141) until the user dismisses the notification using the "x".

Longer until automatically dismissing notifications

Show non-sticky notifications for 10 seconds

Show state

Show "removing/replacing/adding in progress state" while the action is performed on the blockchain -> sticky notifications

Refer to notifications here: https://docs.google.com/spreadsheets/d/1McBmkEKDUIEFec0pvsz46bXpxL5j9dC74wdfLhVw_bY/edit#gid=0

@lukasschor lukasschor added this to the Gnosis Safe for Teams V1.0.0 (Private Beta) milestone Jul 17, 2019
@lukasschor lukasschor self-assigned this Jul 17, 2019
@lukasschor lukasschor changed the title Improvements - Notifications Notifications Improvements Jul 17, 2019
@lukasschor lukasschor modified the milestone: Safe for Teams V1.0.0 (Private Beta) Jul 24, 2019
This was referenced Aug 27, 2019
@germartinez
Copy link
Member

@lukasschor

Notification at the top

We should decide where to place them (top -> left/center/right) knowing that:

  • On the left we may have the left menu opened
  • On the center may be too intrusive ¿?
  • On the right we may have the menu of the current owner opened

Success notifications

I would say for "resolved transactions" whether they success or fail

@mmv08
Copy link
Member

mmv08 commented Aug 28, 2019

@lukasschor
Copy link
Member Author

That's the insights from the user test: "Notification at the right bottom: Seemed 'OK' but would expect them in the right top, closer to where the connected Wallet/account is."
Also, at some point it might make sense to add a notification dropdown at the top with a list of current/past notifications.

For those reasons I would still have them at the top-right even though they might get overlayed with the wallet-details dropdown.

I would say for "resolved transactions" whether they success or fail
Yes, changed the specs

@lukasschor lukasschor added Minor Needs to be fixed within the next 1-3 public releases. Major Needs to be fixed for immediate next public release. and removed Minor Needs to be fixed within the next 1-3 public releases. labels Sep 6, 2019
@germartinez germartinez self-assigned this Sep 10, 2019
@lukasschor lukasschor removed their assignment Sep 11, 2019
germartinez added a commit that referenced this issue Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

No branches or pull requests

3 participants