Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Send Improvements #133

Closed
6 tasks done
lukasschor opened this issue Jul 17, 2019 · 8 comments
Closed
6 tasks done

Send Improvements #133

lukasschor opened this issue Jul 17, 2019 · 8 comments
Assignees
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases.

Comments

@lukasschor
Copy link
Member

lukasschor commented Jul 17, 2019

The improvements below are applicable to all send flows (asset transfer, custom transaction, change owners, change threshold, confirmation, cancellation)

  • Review Text

In the review step, add text at the bottom: "You're about to create a transaction and will have to confirm it with your currently connected wallet. Make sure you have 0.0XX (fee price) ETH in this wallet to fund this confirmation."

  • QR Code inputs
    Add QR code scanner for recipient field

  • Missing whitespace
    Screenshot 2019-10-01 at 09.42.28.png
    There is a whitespace missing between "of" and the number of owners.

  • Execute Transaction as default

Screenshot 2019-09-25 at 17.33.37.png

It is more common that users would like to execute a transaction immediately after all signatures are collected. Therefore the "Execute Transaction" checkbox should be checked by default.

Change phrasing to: "Approving this transaction executes it right away. If you want approve but execute the transaction manually later, click on the checkbox below."

@lukasschor lukasschor self-assigned this Jul 17, 2019
@lukasschor lukasschor added this to the Gnosis Safe for Teams V1.0.0 (Private Beta) milestone Jul 17, 2019
@lukasschor lukasschor changed the title Improvements - Send Send Improvements Jul 17, 2019
@lukasschor lukasschor modified the milestone: Safe for Teams V1.0.0 (Private Beta) Jul 24, 2019
@tschubotz
Copy link
Member

After a transaction is sent, automatically switch to the transaction list view.

In the background or only after the user clocked "Done" on the success screen?

@lukasschor
Copy link
Member Author

I would propose after clicking on done.

@germartinez
Copy link
Member

germartinez commented Aug 27, 2019

@lukasschor @tschubotz
I would not redirect to the transaction screen if we are also going to implement notifications (#135) on the bottom right corner with the real time status of transactions. If I'm adding/removing the owners of a Safe, for example, I would probably prefer to return to the same screen and having a notification showing if the transaction was successfully or not would be enough.

Regarding the review text, we don't have designs for this. I assume the place would be placed were the Advance options (now outdated) in this screen is (without the top border): https://app.zeplin.io/project/5b83b4fa75f90943c86ed14f/screen/5bc9b0bc18676d273203a7e0

@lukasschor
Copy link
Member Author

lukasschor commented Aug 27, 2019

I would not redirect to the transaction screen if we are also going to implement notifications (#135) on the bottom right corner with the real time status of transactions. If I'm adding/removing the owners of a Safe, for example, I would probably prefer to return to the same screen and having a notification showing if the transaction was successfully or not would be enough.

I can see this point. I still feel that I personally would prefer to get redirected to the transaction list but notifications might indeed already solve for this. If everyone else is also in favor of staying on the asset / settings screens I would go with that.

Regarding the review text, we don't have designs for this. I assume the place would be placed were the Advance options (now outdated) in this screen is (without the top border):

Exactly, and sorry about not having screens at this point. @posthnikova is currently reducing the discrepancies between implementation, future implementation & and initial screens. But we will probably still feel the design-debt pain occasionally until Devcon.

@mmv08
Copy link
Member

mmv08 commented Aug 28, 2019

I can see this point. I still feel that I personally would prefer to get redirected to the transaction list but notifications might indeed already solve for this. If everyone else is also in favor of staying on the asset / settings screens I would go with that.

I agree with German that it makes sense for settings page to stay on the same screen. But for send view it may be different. Maybe it's a thing for UX research :)

@lukasschor
Copy link
Member Author

As we haven't yet implemented the transaction list during the first user test, we were not able to get feedback on that. But just talked to Kristina and during the tests at Dappcon, users were looking for more information about the transaction right after sending the transaction and usually gravitated towards the transaction list. In 1-oo-1 cases it might be fine if the view stays the same (asset view or settings) as the user cares more about the actual change (=assets sent out, owners change, etc.) rather than the success of the tx. But especially in x-oo-y cases it makes sense to redirect to the transaction list as an acutal change (e.g. owner change, etc.) can't be expected soon anyways. As only a minority would probably use a 1-oo-1 scheme I would actually optimize for the majority and redirect to the tx list.

@germartinez
Copy link
Member

What about making a reference to the Safe where notifications come from? Could be confusing if the user is renaming/changing the threshold/etc. for all the Safes.

  • Transaction from SuperVault 2000 submitted!
  • Threshold change from SuperVault 2000 submitted!

@lukasschor
Copy link
Member Author

What about making a reference to the Safe where notifications come from? Could be confusing if the user is renaming/changing the threshold/etc. for all the Safes.

Yes I think that makes sense, especially when we have more insights into how people interact with multiple safes and might be part of a future "notification center" or "activity list". I put this on the backlog for now if that's fine for you: https://docs.google.com/spreadsheets/d/1RgYKZMITnFuQQSCmiTGWYNfqFePK8vOMFpfAazEtc7g/edit#gid=0

@lukasschor lukasschor added the Minor Needs to be fixed within the next 1-3 public releases. label Sep 6, 2019
@lukasschor lukasschor modified the milestones: Safe for Teams v1.0.0 (Devcon), Safe for Teams v1.5.0 (Devcon), Safe for Teams v1.1.0 (Devcon - Nice-to have’s) Sep 6, 2019
@lukasschor lukasschor added the Enhancement ✨ Minor Improvement / changes to existing functionality label Oct 1, 2019
mmv08 added a commit that referenced this issue Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Development

No branches or pull requests

4 participants