Feature #133: Send improvements #220

mmv08 · 2019-10-07T10:58:26Z

This PR:

Implements Send Improvements #133
Integrate safe view tabs with react router, they're now /safes/address/transactions|balances|settings
Fix infinite loop from notifier component when hot reload occurs (the problem was reducer's initial state)
Dep bump

…cute' is pre-checked now

ghost · 2019-10-07T11:20:56Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-07T11:23:03Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

…ype imports for notifications

ghost · 2019-10-07T12:50:59Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-07T14:57:15Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-08T09:33:37Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

…efault safe error message typo, use formatAmount for gas costs when opening a safe

ghost · 2019-10-09T10:25:48Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-09T12:53:46Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-11T15:05:22Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-14T12:22:12Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

…mprovements

…ctor

…mount, improve cancelled tx detection

ghost · 2019-10-15T14:10:45Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-15T15:19:14Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-16T08:36:19Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

…timations wip

ghost · 2019-10-16T10:01:14Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-16T14:10:07Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-16T14:17:06Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-16T15:02:22Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

…end-improvements

ghost · 2019-10-16T15:23:49Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-16T15:27:15Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

ghost · 2019-10-16T15:32:07Z

Travis automatic deployment:
https://pr220--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr220--safereactstorybook.review.gnosisdev.com

lukasschor

👍

mmv08 added 8 commits October 4, 2019 15:01

Fix missing whitespace in required confirmation text

0378470

Update sending funds with threshold > 2 test because 'approve and exe…

c38325b

…cute' is pre-checked now

add qr scanner to send funds/send custom tx flows

a113f23

ReviewTx import order fix

4de2e26

Fix sending TX for tokens with decimals other than 24

1902981

Fix a fix for sending TX for tokens with decimals other than 24

b458aa4

Safe view tabs as routes wip

051b677

Integrate material ui tabs with react router

2f13ecc

mmv08 added the WIP label Oct 7, 2019

mmv08 added 2 commits October 7, 2019 15:11

Pull from dev, conflict fixes

5451f32

Remove not needed variable export

7eed741

Switch to transaction list after creating tx, fix typos and missing t…

712fc80

…ype imports for notifications

Transactions gas costs wip

387ea01

Don't show gas calculations in send funds review

d6cce5e

mmv08 removed the WIP label Oct 8, 2019

mmv08 requested review from cag, lukasschor and germartinez and removed request for cag October 8, 2019 09:42

mmv08 added the WIP label Oct 9, 2019

Show gas costs estimation when sending TX (not custom), fix loading d…

4d25c04

…efault safe error message typo, use formatAmount for gas costs when opening a safe

Add gas costs to custom tx, add etherscan/copy btns to send funds flow

769f164

Add etherscan/copy buttons to custom txs flow

c6f5aa4

Dep bump

c63af79

mmv08 added 4 commits October 15, 2019 13:29

Merge branch 'master' of github.com:gnosis/safe-react into 133-send-i…

849ed0a

…mprovements

Refactor send funds token select field to surpress mui warnings

f13cf6d

Fix 'Send max' functionality when sending funds after send funds refa…

75d37a5

…ctor

Fix gas calculation error when confirming tx because of the modal pre…

0dd2ad5

…mount, improve cancelled tx detection

Add owner flow gas estimations WIP

c5a1ece

Add Owner Flow gas estimations

ede3293

AddOwnerModal gas estimations styling fixes, ReplaceOwnerModal gas es…

686a174

…timations wip

ReplaceOwnerModal gas estimations

44b7282

Styling fix

7d580e9

remove owner gas estimations

1eb3695

Cancel transaction gas estimations

2c59442

mmv08 removed the WIP label Oct 16, 2019

mmv08 added 2 commits October 16, 2019 19:20

Merge branch 'development' of github.com:gnosis/safe-react into 133-s…

0ef723c

…end-improvements

dep bump

32b8885

lukasschor approved these changes Oct 17, 2019

View reviewed changes

mmv08 merged commit 377622f into development Oct 18, 2019

mmv08 deleted the 133-send-improvements branch October 18, 2019 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature #133: Send improvements #220

Feature #133: Send improvements #220

mmv08 commented Oct 7, 2019 •

edited

Loading

ghost commented Oct 7, 2019

ghost commented Oct 7, 2019

ghost commented Oct 7, 2019

ghost commented Oct 7, 2019

ghost commented Oct 8, 2019

ghost commented Oct 9, 2019

ghost commented Oct 9, 2019

ghost commented Oct 11, 2019

ghost commented Oct 14, 2019

ghost commented Oct 15, 2019

ghost commented Oct 15, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

lukasschor left a comment

Feature #133: Send improvements #220

Feature #133: Send improvements #220

Conversation

mmv08 commented Oct 7, 2019 • edited Loading

ghost commented Oct 7, 2019

ghost commented Oct 7, 2019

ghost commented Oct 7, 2019

ghost commented Oct 7, 2019

ghost commented Oct 8, 2019

ghost commented Oct 9, 2019

ghost commented Oct 9, 2019

ghost commented Oct 11, 2019

ghost commented Oct 14, 2019

ghost commented Oct 15, 2019

ghost commented Oct 15, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

ghost commented Oct 16, 2019

lukasschor left a comment

Choose a reason for hiding this comment

mmv08 commented Oct 7, 2019 •

edited

Loading