Feature #134: Settings improvements #161

mmv08 · 2019-09-05T12:13:39Z

This PR:

Implements Settings Improvements #134
Notifications were moved out from this ticket to Notifications Improvements #135 because they need some refactors
Remove old transactions route folder

…ustom messages WIP

…ransaction actions able to use it

ghost · 2019-09-05T12:22:16Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-05T13:16:47Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

…4-settings-improvements

ghost · 2019-09-05T14:07:35Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-05T14:37:11Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-05T15:26:12Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

lukasschor · 2019-09-06T09:09:49Z

The Titles have different font styles, should all be same as Modify Safe Name title
The description text should start at the same height for each tab, currently it move slightly up or down when switching tabs.
The “X of Y” pages indicator seem to be slightly misaligned

lukasschor · 2019-09-06T09:19:05Z

In case of 4 or more owners I would leave out the lower line.

4 Owners:

With 5 or more owners both lines are combined together and create a line with double the thickness.

If it's to much work to implement this, it should also be fine like it currently is. 👍

lukasschor · 2019-09-06T09:35:15Z

Few more things:

The Card gets back a non-rounded corner on the top left if the “Safe name” tab is selected
The card should start at the same height as the balances tab at the top, currently it’s a bit lower and “moves down” when switching from balances to settings
Let’s leave out the black “Settings” title on the top left, this was not a requirement so far but during my tests right now it felt like it doesn’t really make sense to display this title there. We do not display a title in the Balances or Transaction list views and its redundant as “SETTINGS” is already display as the selected tab at the top.

lukasschor · 2019-09-06T10:00:53Z

Other than the comments above, I did not find anything else and it meets all product requirements. 👏

…ettings-improvements

ghost · 2019-09-06T11:39:12Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-06T13:12:26Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-06T13:14:26Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-06T13:28:41Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-06T13:32:21Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-06T13:52:35Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-06T13:55:52Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

…e are 4 or more owners

mmv08 · 2019-09-06T14:07:13Z

@lukasschor please review it again, everything should be fixed

ghost · 2019-09-06T14:12:06Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-09T08:54:25Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

…ont jump

ghost · 2019-09-09T10:31:13Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-09T14:43:12Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-10T06:48:41Z

Travis automatic deployment:
https://pr161--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr161--safereactstorybook.review.gnosisdev.com

mmv08 added 12 commits September 3, 2019 12:31

show confirmations(threshold) settings in RO mode

4d0007b

Eslint fix

c0220ed

Fix unique address validator, eslint fixes for settings

d2dad74

update threshold text

19b7777

Safe name change notification, setting style updates

5bc5cea

Add an option to disable table pagination WIP

4dc7563

add prop to disable pagination in table component

cd33d04

Add annotation to manage owners

753e46a

Pass notifications to createTransaction/executeTransaction to allow c…

5901476

…ustom messages WIP

increase minHeight for settings to avoid jumping

0932f34

remove old/unused transactions route code

816b3c5

move notifications to separate file so processTransaction and createT…

3660174

…ransaction actions able to use it

mmv08 added the WIP label Sep 5, 2019

Update font sizes, make control row in settings absolutely positioned

d7c056e

Merge branch '140-rebranding' of github.com:gnosis/safe-react into 13…

c72f311

…4-settings-improvements

Threshold Settings controls rebranding fixes

03ede69

add border radius to row in manage owners settings

5126f08

mmv08 changed the title ~~134 settings improvements~~ Feature #134: Settings improvements Sep 6, 2019

mmv08 removed the WIP label Sep 6, 2019

mmv08 requested review from germartinez and lukasschor September 6, 2019 09:00

Merge branch 'development' of github.com:gnosis/safe-react into 134-s…

8ba86a1

…ettings-improvements

mmv08 added 2 commits September 6, 2019 17:05

fix settings titles from PR comments

6594e23

fix settings description from PR comments

71c8b8f

mmv08 added 2 commits September 6, 2019 17:22

Fix X of Y annotations in the modals

dac7bbd

Fix non-rounded corner when choosing 'Safe name' in safe settings

0337d61

mmv08 added 2 commits September 6, 2019 17:46

Make sure that token list/settings tabs don't jump when switching

574b207

Fix hairline and tab bottom border for tabs on safe view page

91992cc

Remove border bottom in manage owners settings for last owner if ther…

bac99f6

…e are 4 or more owners

Add space in remove safe modal annotation

128830e

Make 'Remove Safe' and 'Manage tokens' positioning the same so they d…

89dd6f2

…ont jump

Manage owners responsiveness fix

b53441b

Update owners description

414e9ec

germartinez approved these changes Sep 10, 2019

View reviewed changes

mmv08 merged commit 4ed4fa5 into development Sep 10, 2019

mmv08 deleted the 134-settings-improvements branch September 10, 2019 07:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature #134: Settings improvements #161

Feature #134: Settings improvements #161

mmv08 commented Sep 5, 2019 •

edited

Loading

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

lukasschor commented Sep 6, 2019

lukasschor commented Sep 6, 2019

lukasschor commented Sep 6, 2019

lukasschor commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

mmv08 commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 9, 2019

ghost commented Sep 9, 2019

ghost commented Sep 9, 2019

ghost commented Sep 10, 2019

Feature #134: Settings improvements #161

Feature #134: Settings improvements #161

Conversation

mmv08 commented Sep 5, 2019 • edited Loading

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

ghost commented Sep 5, 2019

lukasschor commented Sep 6, 2019

lukasschor commented Sep 6, 2019

lukasschor commented Sep 6, 2019

lukasschor commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 6, 2019

mmv08 commented Sep 6, 2019

ghost commented Sep 6, 2019

ghost commented Sep 9, 2019

ghost commented Sep 9, 2019

ghost commented Sep 9, 2019

ghost commented Sep 10, 2019

mmv08 commented Sep 5, 2019 •

edited

Loading