Add PHPCS linting #24
Conversation
.gitignore
Outdated
| .DS_Store | ||
| node_modules | ||
| vendor/* | ||
| !vendor/composer |
There was a problem hiding this comment.
possibly we could ignore these and include them later in a build step
| @@ -70,21 +70,26 @@ function enqueue_scripts( $hook ) { | |||
| } | |||
|
|
|||
| // Enqueue the styles. | |||
| wp_enqueue_style( 'admin_tenup-auto-tweet', TUAT_URL . '/assets/css/admin-auto_tweet.css', TUAT_VERSION ); | |||
| wp_enqueue_style( 'admin_tenup-auto-tweet', TUAT_URL . '/assets/css/admin-auto_tweet.css', [], TUAT_VERSION ); | |||
includes/admin/post-meta.php
Outdated
| TUAT_VERSION, | ||
| true | ||
| ); | ||
|
|
||
| $post_id = get_the_ID(); | ||
| if ( empty( $post_id ) ) { | ||
| $post_id = filter_input( INPUT_GET, 'post', FILTER_VALIDATE_INT ); |
There was a problem hiding this comment.
is this change for linting purposes? previously we cast the input to an int, so a string of '1' would get cast to 1. Will FILTER_VALIDATE_INT reject non ints? are we sure these values aren't arriving here as strings?
includes/admin/post-meta.php
Outdated
| TUAT_VERSION, | ||
| true | ||
| ); | ||
|
|
||
| $post_id = get_the_ID(); | ||
| if ( empty( $post_id ) ) { | ||
| $post_id = filter_input( INPUT_GET, 'post', FILTER_VALIDATE_INT ); |
There was a problem hiding this comment.
is this change for linting purposes? previously we cast the input to an int, so a string of '1' would get cast to 1. Will FILTER_VALIDATE_INT reject non ints? are we sure these values aren't arriving here as strings?
There was a problem hiding this comment.
Let's .gitignore the entire vendor directory so we can avoid changes there.
We don't need the plugin to run without a composer install from master. We will add a build process to bundle up the code required for a release, including the correct vendor directories.
|
Thanks, @adamsilverstein! As with the other PR, I've updated to ignore the entire vendor directory. Regarding your Thanks for your feedback! Let me know if you think this is ready to merge. There might be a conflict with the PHPUnit PR for me to resolve |
Description of the Change
This makes the following updates to resolve #3 :
lintandlint-fixcomposer scriptspackage.jsonfile and installshuskyandlint-stageddev dependenciespre-commithook to run PHPCS before commits.I also ran PHPCS against the project once. There was only a handful of issues -- all in
post-meta.php-- so I fixed them. I also removed a fewinput var okcomments that aren't needed for the standard we're using.Potential conflict
Merge conflicts around Composer may need to be worked out between this and #23.