Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPCS linting #24

Merged
merged 12 commits into from
Jul 19, 2019
Merged

Add PHPCS linting #24

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2e5d452
Add 10up phpcs composer package and create phpcs config file
johnwatkins0 Jul 11, 2019
e65e645
PHPCS fixes
johnwatkins0 Jul 11, 2019
9a7044b
Ignore vendor directory
johnwatkins0 Jul 11, 2019
3d98e3c
Unignore non-dev dependencies in vendor
johnwatkins0 Jul 11, 2019
3c1a99a
Remove unneeded 'input var ok' comments
johnwatkins0 Jul 11, 2019
6c54807
Remove unneeded composer.json config
johnwatkins0 Jul 12, 2019
d0a6efa
Use husky and lint-staged to add PHPCS to pre-commit hook
johnwatkins0 Jul 12, 2019
36d58cb
Update lint-staged php script
johnwatkins0 Jul 12, 2019
8d3fe56
Update composer lint script
johnwatkins0 Jul 12, 2019
bb5521a
Ignore entire vendor directory
johnwatkins0 Jul 17, 2019
95a568b
.gitignore - Ignore entire vendor directory
johnwatkins0 Jul 17, 2019
ff61842
Revert input sanitization change and update phpcs ignore comment
johnwatkins0 Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.DS_Store
node_modules
vendor/*
!vendor/composer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly we could ignore these and include them later in a build step

!vendor/abraham
7 changes: 7 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,12 @@
],
"require": {
"abraham/twitteroauth": "^0.7.4"
},
"require-dev": {
"10up/phpcs-composer": "dev-master"
},
"scripts": {
"lint": "./vendor/bin/phpcs --extensions=php --severity=3 -s .",
"lint-fix": "./vendor/bin/phpcbf ."
}
}
Loading