Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phpcs linting [2 hrs.] #3

Closed
adamsilverstein opened this issue Jan 28, 2019 · 4 comments · Fixed by #24
Closed

Add phpcs linting [2 hrs.] #3

adamsilverstein opened this issue Jan 28, 2019 · 4 comments · Fixed by #24
Assignees
@johnwatkins0
Labels
type:enhancement New feature or request.
Milestone
1.0.0

Comments

@adamsilverstein
Copy link

No description provided.

@jeffpaul jeffpaul added this to the 0.2.0 milestone Jan 28, 2019
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 4, 2019
@adamsilverstein adamsilverstein changed the title Add linting Add phpcs linting Feb 15, 2019
@adamsilverstein
Copy link
Author

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards

@adamsilverstein adamsilverstein changed the title Add phpcs linting Add phpcs linting [2 hrs.] Feb 25, 2019
@adamsilverstein
Copy link
Author

adamsilverstein commented Feb 25, 2019 •
edited
Loading

Note: depending on the volume of issues found we can either correct them as part of this issue or spin up a separate issue to address them.

@johnwatkins0 johnwatkins0 self-assigned this Jul 11, 2019
@johnwatkins0
Copy link
Member

Hi, @adamsilverstein . Just wondering -- is there a reason we would use the WP coding standards over the 10up PHPCS package for this?

@johnwatkins0 johnwatkins0 mentioned this issue Jul 12, 2019
Merged
@adamsilverstein
Copy link
Author

@johnwatkins0 I can't think of one. Since its a 10up project I would be inclined to use our standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnwatkins0 johnwatkins0

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add PHPCS linting 10up/autoshare-for-twitter
3 participants
@adamsilverstein @jeffpaul @johnwatkins0