Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Run E2E tests on generated release zip #206

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Dec 2, 2022

Description of the Change

PR contains changes to Run E2E tests on the zip generated by "Build release zip" action to catch release zip bugs early and at the PR level instead of manual testing before release.

How to test the Change

I tried deleting the .distignore file to generate a zip without the vendor folder and verified that the E2E tests fail.

Changelog Entry

Changed - Run E2E tests on the zip generated by "Build release zip" action.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh marked this pull request as ready for review December 2, 2022 06:19
@github-actions github-actions bot added the needs:code-review This requires code review. label Dec 2, 2022
@iamdharmesh iamdharmesh added this to the 1.3.0 milestone Dec 2, 2022
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
It is a helpful addition, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants