Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node cache to include Cypress #212

Merged
merged 5 commits into from
Dec 16, 2022
Merged

Fix node cache to include Cypress #212

merged 5 commits into from
Dec 16, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Dec 14, 2022

Description of the Change

In #206, a node cache was introduced, but it did not include Cypress binaries. That's why, with the warm cache, cypress tasks failed.

The current PR fixes that by adding ~/.cache and ~/.npm to cached directories list.

Closes #211

How to test the Change

Tested with the following scenario:

  1. Run the job for the first time (cold cache). See the cache is not exist, Cypress expected to run correctly. Cache should be created.
  2. Re-run the job to test with warm cache. See the cache is downloaded and Cypress run correctly again (it was not before this change). Cache should not be overwritten.

I was forcing E2E tests to run by temporary disabling path filtering in 4f7f1de

Changelog Entry

Fixed - E2E tests fail in the CI with warm cache

Credits

@cadic

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@cadic cadic marked this pull request as ready for review December 14, 2022 07:21
@cadic cadic requested a review from iamdharmesh December 14, 2022 07:21
@cadic cadic added this to the 1.3.0 milestone Dec 14, 2022
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Dec 14, 2022
@github-actions
Copy link
Contributor

@cadic thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Dec 14, 2022
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @cadic, LGTM 🚀

@iamdharmesh iamdharmesh merged commit 84e6459 into develop Dec 16, 2022
@iamdharmesh iamdharmesh deleted the fix/211 branch December 16, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress tests fail
2 participants