Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run E2E tests on the zip generated by "Build release zip" action. #126

Closed
1 task done
iamdharmesh opened this issue Dec 22, 2022 · 0 comments · Fixed by #128
Closed
1 task done

Run E2E tests on the zip generated by "Build release zip" action. #126

iamdharmesh opened this issue Dec 22, 2022 · 0 comments · Fixed by #128
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone
1.3.2

Comments

@iamdharmesh
Copy link
Member

Is your enhancement related to a problem? Please describe.

We are currently running E2E tests by installing dependencies and building plugin files. This is not the most accurate plugin build that will be shipped during the release. To make E2E tests more accurate and match the plugin build with the release build generated by our deploy action, we should generate a plugin build with the "build zip" action. Running E2E tests on this build will give us more accurate results.

PR for reference: 10up/autoshare-for-twitter#206

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iamdharmesh iamdharmesh added the type:enhancement New feature or request. label Dec 22, 2022
@iamdharmesh iamdharmesh added this to the Future Release milestone Dec 22, 2022
@iamdharmesh iamdharmesh moved this from Incoming to To Do in Open Source Practice Dec 22, 2022
@iamdharmesh iamdharmesh moved this to Incoming in Open Source Practice Dec 22, 2022
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Dec 22, 2022
@faisal-alvi faisal-alvi modified the milestones: Future Release, 1.3.2 Jan 13, 2023
@faisal-alvi faisal-alvi mentioned this issue Jan 13, 2023
Merged
4 tasks
@faisal-alvi faisal-alvi moved this from To Do to In Review in Open Source Practice Jan 13, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Feat: Run E2E tests on generated release zip 10up/publisher-media-kit
3 participants
@jeffpaul @iamdharmesh @faisal-alvi