Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating dependencies, addressing compiler warnings #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updating dependencies, addressing compiler warnings #53

wants to merge 1 commit into from

Conversation

jeffgrunewald
Copy link

This PR is intended to update dependencies and address compiler warnings raised in newer versions of Elixir (1.11+)

With the shift to Elixir 1.11 and OTP 23 and above, dependencies expressly called on in an application that are not either a) included in the :extra_applications config of an app or b) listed in the app's dependencies will throw a compiler warning about implicit runtime dependencies. Since the :crypto module is built into Erlang, this should be added to the extra applications configuration to address this issue going forward.

I've also modified the version key based on the small size of the proposed change and my own take on semver but feel free to suggest a different version number change that you prefer.

Thanks so much!

@Hentioe
Copy link

Hentioe commented Jul 1, 2021

This modification is meaningful and can eliminate some compilation warnings. @zyro

@Hentioe
Copy link

Hentioe commented Jul 1, 2021

Unfortunately, the author does not seem to maintain this library anymore. Hope this library can be donated to others for maintenance 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants