Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression de la librairie exshape (et elixir_uuid) #1695

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Jul 6, 2021

En travaillant sur #1691 et #1683, j'ai vu que la librairie elixir_uuid générait des warnings importants (voir plus bas).

En cherchant à comprendre les warnings, j'ai réalisé que elixir_uuid n'était pas activement maintenue actuellement, et que d'autres personnes attendaient un merge de PR qui corrige ces points (zyro/elixir-uuid#53).

Devant ce constat, j'ai été voir à quoi servait cette librairie pour nous. J'ai compris que c'était une dépendance de exshape (https://hex.pm/packages/exshape), qui sert à lire des fichiers shapefile ESRI.

En enquêtant, j'ai déterminé que cette dépendance avait été ajoutée il y a un moment pour la partie GBFS (#732), mais que le code avait été après coup modifié pour ne plus utiliser ce format.

La dépendance est elle restée en place.

Je la supprime pour qu'on puisse rayer cette dépendance de la liste de celles à mettre à jour, et éliminer du travail.

Pour information

J'ai utilisé la commande mix deps.clean --unlock --unused pour purger le lock file. En pratique elle supprime aussi une autre librairie, mais je ferai une PR séparée.

Logs de compilation d'elixir_uuid

==> elixir_uuid
Compiling 1 file (.ex)
warning: :crypto.hash/2 defined in application :crypto is used by the current application but the current application does not depend on :crypto. To fix this, you must do one of:

  1. If :crypto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :crypto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :crypto, you may optionally skip this warning by adding [xref: [exclude: [:crypto]]] to your "def project" in mix.exs

Found at 2 locations:
  lib/uuid.ex:589: UUID.namebased_uuid/2
  lib/uuid.ex:593: UUID.namebased_uuid/2

warning: :crypto.strong_rand_bytes/1 defined in application :crypto is used by the current application but the current application does not depend on :crypto. To fix this, you must do one of:

  1. If :crypto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :crypto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :crypto, you may optionally skip this warning by adding [xref: [exclude: [:crypto]]] to your "def project" in mix.exs

Found at 3 locations:
  lib/uuid.ex:383: UUID.uuid4/1
  lib/uuid.ex:560: UUID.uuid1_clockseq/0
  lib/uuid.ex:583: UUID.uuid1_node/1

Generated elixir_uuid app

@thbar thbar requested review from andlio and fchabouis July 6, 2021 07:43
@thbar thbar added the dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité label Jul 6, 2021
@thbar thbar self-assigned this Jul 6, 2021
@thbar
Copy link
Contributor Author

thbar commented Jul 6, 2021

Merci @andlio pour la review !

@thbar thbar merged commit 7883794 into master Jul 6, 2021
@thbar thbar deleted the remove-exshape branch July 6, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants