Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: topics and hass ids/names fixes #247

Merged
merged 19 commits into from
Jan 21, 2021
Merged

fix: topics and hass ids/names fixes #247

merged 19 commits into from
Jan 21, 2021

Conversation

robertsLando
Copy link
Member

Fixes #239 #232

@robertsLando robertsLando changed the title fix: usage of propertyKey/name fix: topics and hass ids/names fixes Jan 15, 2021
@coveralls
Copy link

coveralls commented Jan 15, 2021

Pull Request Test Coverage Report for Build 501193487

  • 10 of 75 (13.33%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 22.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/MqttClient.js 0 1 0.0%
lib/Constants.js 0 2 0.0%
lib/ZwaveClient.js 0 7 0.0%
lib/utils.js 5 26 19.23%
lib/Gateway.js 5 39 12.82%
Files with Coverage Reduction New Missed Lines %
lib/utils.js 2 51.61%
lib/Gateway.js 9 17.85%
Totals Coverage Status
Change from base Build 500872642: 0.1%
Covered Lines: 1946
Relevant Lines: 8678

💛 - Coveralls

@robertsLando
Copy link
Member Author

I need tests on this bdbogjoe

@bdbogjoe
Copy link

bdbogjoe commented Jan 19, 2021

still having
2021-01-19 21:27:37.163 INFO ZWAVE: Node 8: metadata updated: 50-1-value-65537
log.zip

@robertsLando
Copy link
Member Author

robertsLando commented Jan 20, 2021

still having

What's wrong with that? That will never change, it's the value id and it's unique, coming from zwave-js not decided by me

@bdbogjoe
Copy link

ok i thought you wanted to rename this to have like /Power for some devices

@robertsLando robertsLando force-pushed the fix-property-key branch 2 times, most recently from 7397395 to b3a964b Compare January 21, 2021 09:45
lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
@robertsLando robertsLando merged commit a072c73 into master Jan 21, 2021
@robertsLando robertsLando deleted the fix-property-key branch January 21, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] propertyKeyName should be used instead of propertyKey if it exists
3 participants