Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] propertyKeyName should be used instead of propertyKey if it exists #239

Closed
AlCalzone opened this issue Jan 14, 2021 · 3 comments · Fixed by #247
Closed

[bug] propertyKeyName should be used instead of propertyKey if it exists #239

AlCalzone opened this issue Jan 14, 2021 · 3 comments · Fixed by #247
Assignees
Labels
bug Something isn't working

Comments

@AlCalzone
Copy link
Member

Found several locations where propertyName is used in place of property, but the same does not happen for propertyKeyName.

Also, this is completely wrong I think (propertyName instead of propertyKeyName):
https://github.com/zwave-js/zwavejs2mqtt/blob/6e2a0f726aa8f14bc06258860c002e6373697f05/lib/Gateway.js#L678

@AlCalzone
Copy link
Member Author

@robertsLando
Copy link
Member

Thanks, will look at this later

@bdbogjoe
Copy link

do you need any testing on this ?

robertsLando added a commit that referenced this issue Jan 21, 2021
* fix: sanitize slash in properties

* fix: better id sanification

* fix: lint errors

* fix: other lint errors

* fix: usage of propertyKey/name

Fixes #239 #232

* fix: joinProps helper and sanitize object id

* fix: move sanitifaction methods to utils

* fix: lint issues

* fix: sanification of numbers

* fix: typo

* fix: remove meter type from meters object id

* fix: add missing toLowerCase

* fix: add missing toLowerCase

* fix: lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants