-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] propertyKeyName should be used instead of propertyKey if it exists #239
Comments
propertyKeyName is missing completely here: This should also append the propertyKey(Name) to uniquely identify the value: This confuses propertyKey with property (should be the other way round): This looks up the sensor type manually: This should probably use |
Thanks, will look at this later |
do you need any testing on this ? |
* fix: sanitize slash in properties * fix: better id sanification * fix: lint errors * fix: other lint errors * fix: usage of propertyKey/name Fixes #239 #232 * fix: joinProps helper and sanitize object id * fix: move sanitifaction methods to utils * fix: lint issues * fix: sanification of numbers * fix: typo * fix: remove meter type from meters object id * fix: add missing toLowerCase * fix: add missing toLowerCase * fix: lint issues
Found several locations where
propertyName
is used in place ofproperty
, but the same does not happen forpropertyKeyName
.Also, this is completely wrong I think (
propertyName
instead ofpropertyKeyName
):https://github.com/zwave-js/zwavejs2mqtt/blob/6e2a0f726aa8f14bc06258860c002e6373697f05/lib/Gateway.js#L678
The text was updated successfully, but these errors were encountered: