feat: rework route rebuilding to use task scheduler #7196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Sep 27, 2024
AlCalzone
added a commit
that referenced
this pull request
Oct 7, 2024
This release adds an internal task scheduler that will allow more control over longer running tasks like device interviews, route rebuilding, firmware updates, etc. These improvements include pausing/resuming tasks, better prioritization for user-initiated actions, queueing tasks without interrupting ongoing ones, and more. Migration of existing features to the new scheduler will be done incrementally, starting with route rebuilding. ### Features * Reworked route rebuilding to use the task scheduler. This enables rebuilding routes for multiple individual nodes at once. (#7196, #7203) ### Bugfixes * Fixed a regression from `13.4.0` that prevented restoring NVM backups on 700/800 series controllers (#7220) ### Config file changes * Add fingerprint to Aeotec ZWA024 (#7191) * Correct max. value of SKU parameters for Kwikset locks (#7178) * Add fingerprint to Remotec ZXT-800 (#7195) ### Changes under the hood * Implement task scheduler (#7193) * Upgrade to ESLint v9, typescript-eslint v8 (#6987) * Update FAQ on secondary controllers (#7190)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, rebuilding routes of individual nodes or the entire network uses the new task scheduler introduced in #7193.
This means that
beginRebuildingRoutescan now be called while individual node rebuilds are pending, andrebuildNodeRoutescan be called for multiple nodes without having to wait for the previous rebuild to finish.Overlapping tasks are reused, so if
rebuildNodeRoutesis has queued a task to rebuild routes for one node, a concurrentbeginRebuildingRouteswill wait for the queued task instead of queued another one.solves one part of #3707