refactor: handle Basic CC interview separately, be very explicit when the CC is considered supported #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
force-pushed
the
skip-basic-cc-interview-if-not-allowed
branch
from
b770d7c to
92589dc
Compare
AlCalzone
changed the title
currentValue if Basic Set is mapped to another CC
AlCalzone
changed the title
currentValue if Basic Set is mapped to another CC
|
@zwave-js-bot automerge |
zwave-js-bot
previously approved these changes
Jul 8, 2024
zwave-js-bot
approved these changes
Jul 9, 2024
AlCalzone
added a commit
that referenced
this pull request
Jul 9, 2024
### Bugfixes * Fixed an issue where `Basic CC` values would be exposed unnecessarily for devices with a compat flag that maps `Basic CC Set` to a different CC (#6984)
AlCalzone
added a commit
that referenced
this pull request
Jul 9, 2024
… the CC is considered supported (#6984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Basic CC was interviewed as part of the normal CC interview machinery, but with added modifications inbetween steps. This made determining whether the CC is (supposed to be) supported very fragile and lead to confusing heuristics.
We now interview the Basic CC for the root device and all endpoints at the very end of the interview, and determine then whether the CC is supported and/or controlled.
In addition,
currentValueis no longer exposed when the CC is controlled and Basic Sets are mapped to a different CC.