feat: add compat flag to override (almost) arbitrary CC API queries #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2023
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Jul 10, 2023
AlCalzone
added a commit
that referenced
this pull request
Jul 10, 2023
### Config file changes * Add missing product type to `Aeotec Water Sensor 7 Basic ZWA018` (#5989) * Override endpoint indizes for `heatapp! floor` (#5994) * Override schedule slot count for `P-KFCON-MOD-YALE` (#5991) * Override supported color channels for `Zipato RGBW Bulb2` (#5993) * Override supported thermostat modes for Z-Wave.me ZME_FT (#5997) ### Changes under the hood * Fixed a typo in the `discoverNodeNeighbors` JSDoc (#5984) * Added Node.js 20 to the test matrix (#5983) * Added a compat flag to override (almost) arbitrary CC API queries (#5987, #5995) * Added the `yarn configfind ...` CLI command to quickly find a config file by ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of device issues are caused by incorrect responses to certain queries. This PR attempts to solve this issue by declaratively overriding what a CC API call returns and which values need to be stored in the value DB. It is set up this way, because device interviews internally use the CC API methods.
By hooking into this process, we simply skip the original API call and simulate the result.
This allows us to avoid interview-specific implementations and provides a framework to solve this issue for most problematic devices.
closes: #4609
fixes: #1625