Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat flag to override values reported by a device #1625

Closed
AlCalzone opened this issue Feb 6, 2021 · 9 comments · Fixed by #5987
Closed

Add compat flag to override values reported by a device #1625

AlCalzone opened this issue Feb 6, 2021 · 9 comments · Fixed by #5987

Comments

@AlCalzone
Copy link
Member

To work around this device firmware (!) issue on the zwave-js side, we need to add a compat flag that allows us to override specific values and avoid querying them from the device (because in this case the supported colors response is simply wrong).

Originally posted by @AlCalzone in zwave-js/zwave-js-ui#477 (comment)

@scyto
Copy link
Contributor

scyto commented Feb 6, 2021

Is this fix required per device definition file or somewhere else?
Is this just new integration specific or would apply to the MQTT hass discovery code path?

@AlCalzone
Copy link
Member Author

This needs to be done in the device config files where necessary to fix wrong device-specific capability reports.

In the mentioned issue, the device does not report that it supports the blue color channel, based on which the channel is not queried by zwave-js and RGB (hex) support is assumed to be false.

@scyto
Copy link
Contributor

scyto commented Feb 6, 2021

thanks, could this be the root cause on the fibaro rgbw v1?
Z-Wave-Me/z-way-issues#163 (comment)

this person has indicate the device has a pretty bad bug on reporting channels....

I can take point on the fibaro rgbw file if someone tells me what to add (folks seem to mentioning difference devices so i assume we will need to edit multiple device files)

@AlCalzone
Copy link
Member Author

That looks different

@joselito11
Copy link

joselito11 commented Mar 15, 2021

Will be some update on version 7 for this rgb bug?

@AlCalzone
Copy link
Member Author

Sorry, that would require a larger rework of the interview process where I'd have to touch every CC implementation in several locations.

@joselito11
Copy link

So on HA core-2021.4.0b0 and with zwaveJS addon 0.1.15 the light has color wheel, must click few times to get the color, but it works! Thanks!
Zaslonska slika 2021-04-01 12-01-39
Zaslonska slika 2021-04-01 12-01-53

@AlCalzone
Copy link
Member Author

I didn't do anything here 😳

@joselito11
Copy link

joselito11 commented Jun 5, 2021

Color picker is gone again, any idea how to get it back? Have deleted zwavejs integration, reinstalled addon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants