Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-re-enable Sentry on Android, this time with no libsentry.so #5783

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Re-re-enable Sentry on Android, this time with no libsentry.so #5783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb9abdc
sentry: Cut Sentry's native code on Android entirely
gnprice Oct 31, 2023
bdcdd83
sentry: Re-enable Sentry on Android, take 2
gnprice Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,14 @@ android {
}
}

// Disable all Sentry's native code. This doesn't seem to impair
// Sentry's reporting of JVM or JS exceptions. Suggested by
// upstream:
// https://github.com/getsentry/sentry-java/issues/2955#issuecomment-1765732363
configurations.configureEach {
exclude group: "io.sentry", module: "sentry-android-ndk"
}

repositories {
mavenCentral()
}
Expand Down
9 changes: 6 additions & 3 deletions docs/howto/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,12 @@ simple terminology for the process we follow with both.
tools/checkout-keystore
```

* Do *not* apply the Sentry client key from the `release-secrets`
branch; if you're already on that branch (from e.g. making the iOS
build), move off of it. See our issues #5757 and #5766.
* Apply the Sentry client key (using the local branch created for this
in initial setup):

```
git rebase @ release-secrets
```

* Build the app, as both good old-fashioned APKs and a fancy new AAB:

Expand Down
6 changes: 2 additions & 4 deletions tools/android
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,14 @@ do_apk() {
check_yarn_link
run_visibly yarn

# TODO(#5766): start passing -Psentry again
run_visibly tools/gradle :app:assembleRelease -Psigned
run_visibly tools/gradle :app:assembleRelease -Psigned -Psentry
}

do_aab() {
check_yarn_link
run_visibly yarn

# TODO(#5766): start passing -Psentry again
run_visibly tools/gradle :app:bundleRelease -Psigned
run_visibly tools/gradle :app:bundleRelease -Psigned -Psentry
}

case "${action}" in
Expand Down
Loading