Re-re-enable Sentry on Android, this time with no libsentry.so #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toward zulip#5782. I've tested, on a build with this change and then Sentry enabled, that: * The APK is free of any native libraries that have an obvious relationship to Sentry, in particular `libsentry.so` and `libsentry-android.so` which appear without this change. * In brief manual testing of the app, nothing goes obviously wrong. So at least Sentry doesn't, say, cause a crash at startup whenever it can't find `libsentry.so`. * Upon adding some artificial warnings and errors, they show up in the Sentry dashboard. This includes `logging.warn` in JS; uncaught exceptions in JS; `ZLog.w` in Kotlin; and an uncaught exception in Kotlin in handling a notification. I also tried an uncaught exception in Kotlin in a `@ReactMethod` implementation, and that one didn't work. But I think that's mostly React Native's fault, and is likely not a regression: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/re-enabling.20Se ntry/near/1654173 The big remaining question to resolve is whether this causes some crashes in the wild. Given that the native code is gone, that isn't real likely; but having been burned before, we'll want to be a bit cautious, by validating this with a solid beta period.
This reverts commit 033a9d6. Fixes: zulip#5782
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5782.
I've tested, on a build with these changes and Sentry enabled, that:
The APK is free of any native libraries that have an obvious
relationship to Sentry, in particular
libsentry.soandlibsentry-android.sowhich appear without this change.In brief manual testing of the app, nothing goes obviously wrong.
So at least Sentry doesn't, say, cause a crash at startup whenever
it can't find
libsentry.so.Upon adding some artificial warnings and errors, they show up in
the Sentry dashboard. This includes
logging.warnin JS; uncaughtexceptions in JS;
ZLog.win Kotlin; and an uncaught exceptionin Kotlin in handling a notification.
I also tried an uncaught exception in Kotlin in a
@ReactMethodimplementation, and that one didn't work. But I think that's
mostly React Native's fault, and is likely not a regression:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/re-enabling.20Sentry/near/1654173
The big remaining question to resolve is whether this causes some
crashes in the wild. Given that the native code is gone, that
isn't real likely; but having been burned before, we'll want to be
a bit cautious, by validating this with a solid beta period.