Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Sentry on Android, with enableNdk: false #5765

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Re-enable Sentry on Android, with enableNdk: false #5765

merged 4 commits into from
Oct 5, 2023

Commits on Oct 5, 2023

  1. deps: Upgrade @sentry/react-native to 5.9.2 

    Done by following the upgrade guide at
  https://docs.sentry.io/platforms/react-native/migration/
starting in the "From 3.x to 4.x" section and working up through
"From 4.x to 5.x".

Not many declared breaking changes relevant to our app:
- The `Severity` enum is removed in favor of string literals
- The Sentry CLI had a big upgrade with declared breaking changes
  to handle in our iOS build

We leave our existing hand-edited type definitions in place,
even though they're doubtless increasingly out of date.
Given that we're planning to mothball this codebase fairly soon,
it's not worth the effort to try to systematically update them.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6481927 View commit details
    Browse the repository at this point in the history

  2. deps: Upgrade @sentry/react-native to 5.10.0 

    This introduces the `enableNdk` option at Sentry initialization time:
  getsentry/sentry-react-native@2c394d1

We add that option to our hand-edited type definitions, because we
intend to use it.
    @gnprice
    gnprice committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    49b0913 View commit details
    Browse the repository at this point in the history

  3. sentry: Disable Sentry native code on Android 

    Using the new option added in @sentry/react-native 5.10.0:
  https://github.com/getsentry/sentry-react-native/releases/tag/5.10.0

Greg found in testing:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/re-enabling.20Sentry/near/1654140

that this, plus re-enabling Sentry on Android (coming up) seems
adequate for zulip#5766.
    @gnprice
    gnprice committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1510bd3 View commit details
    Browse the repository at this point in the history

  4. sentry: Re-enable Sentry again (on Android) 

    This reverts commit e8c57e7,
except for its updates to the changelog.

Fixes: zulip#5766
    @gnprice
    gnprice committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f792c39 View commit details
    Browse the repository at this point in the history