Re-enable Sentry on Android (without crashes) #5766
Comments
gnprice
added
a-Android
upstream: other
This is a workaround for zulip#5757, the crashes we've started to regularly see as many users' devices have started taking the Google Play system update dated 2023-08. See the (long) chat thread here: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crashes/near/1640893 and issue threads reported in Android's and Sentry's trackers: https://issuetracker.google.com/issues/300840851 https://github.com/getsentry/sentry-unity/issues/1444 Our issue for re-enabling Sentry on Android is zulip#5766. This commit was cherry-picked from 29cea89, part of v27.213, with tweaks to mention zulip#5766.
|
(#5768 is what does the disabling in |
This is a workaround for #5757, the crashes we've started to regularly see as many users' devices have started taking the Google Play system update dated 2023-08. See the (long) chat thread here: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crashes/near/1640893 and issue threads reported in Android's and Sentry's trackers: https://issuetracker.google.com/issues/300840851 https://github.com/getsentry/sentry-unity/issues/1444 Our issue for re-enabling Sentry on Android is #5766. This commit was cherry-picked from 29cea89, part of v27.213, with tweaks to mention #5766.
|
Quickly tagging #5741 here as possibly relevant as this release is the first time my Android 14 Pixel 5 has stopped crashing every 30 seconds. It has been non-stop crashes for a few months. I'm running zulip mobile android v27.213 which is finally happy / not crashing. |
|
@darren1713 Very interesting! Thanks for that update. Glad the app is running crash-free for you again. Just to repeat for this thread some of the context in that one: you first reported the crashes 2023-06-06, and they'd started when you upgraded to Android 14. At that time I suppose you can't have been on the Google Play system update dated August 2023. That's interesting because it otherwise appears that this Sentry-related bug is only triggered (or only triggered frequently, at least) with that update; so perhaps that only applies to Android 13 and Android 12, and Android 14 is enough to trigger it on its own. |
I think we're getting events with #5741's error output much more frequently on Android versions other than 14, than on Android 14. And in both cases, the frequency graph doesn't have the ominous-uptick shape that was characteristic of the crashes that became the focus of #5757. (These observations came up in an internal conversation but looks like I never updated #5741 with that information, oops.) |
|
Ah thanks. I replied over on #5741, at #5741 (comment) ; that's probably the thread for further discussion in that direction. |
Using the new option added in @sentry/react-native 5.10.0: https://github.com/getsentry/sentry-react-native/releases/tag/5.10.0 Greg found in testing that this, plus re-enabling Sentry on Android (coming up) seems adequate for zulip#5766.
This reverts commit e8c57e7, except for its updates to the changelog. Fixes: zulip#5766
Using the new option added in @sentry/react-native 5.10.0: https://github.com/getsentry/sentry-react-native/releases/tag/5.10.0 Greg found in testing: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/re-enabling.20Sentry/near/1654140 that this, plus re-enabling Sentry on Android (coming up) seems adequate for zulip#5766.
In order to resolve the crash bug #5757, we've disabled Sentry error reporting for our Android releases. See details at #5757 (comment) , and the (long) chat thread around https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crashes/near/1643296 .
We should re-enable Sentry so that we have error reporting again, but without the crashes.
Possible ways to do that include:
Wait for Sentry upstream to find and release a fix. Their issue thread is The number of Crashes and ANRs has increased getsentry/sentry-java#2955 .
Re-enable Sentry reporting of events that arise in our JS and Kotlin code (both those we explicitly report, and uncaught exceptions), but without enabling Sentry's native code.
It's not clear whether this is possible; see chat discussion at https://chat.zulip.org/#narrow/stream/48-mobile/topic/Sentry.20crash.20bug/near/1644261 .
If the price of this were that we didn't get reporting of errors that happen within native code, that would be fine.
Some other workaround.
The text was updated successfully, but these errors were encountered: