Skip to content

Commit

Permalink
sentry: Disable Sentry again on Android
Browse files Browse the repository at this point in the history
This reverts commit f792c39, and effectively reinstates
commit e8c57e7.  It's aimed as a workaround for #5778,
which appears to revive #5757.  See chat thread:
  https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crash.20.23M5778/near/1659732
  • Loading branch information
gnprice committed Oct 10, 2023
1 parent 698cde1 commit 033a9d6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
9 changes: 3 additions & 6 deletions docs/howto/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,9 @@ simple terminology for the process we follow with both.
tools/checkout-keystore
```

* Apply the Sentry client key (using the local branch created for this
in initial setup):

```
git rebase @ release-secrets
```
* Do *not* apply the Sentry client key from the `release-secrets`
branch; if you're already on that branch (from e.g. making the iOS
build), move off of it. See our issues #5757 and #5766.

* Build the app, as both good old-fashioned APKs and a fancy new AAB:

Expand Down
6 changes: 4 additions & 2 deletions tools/android
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ do_apk() {
check_yarn_link
run_visibly yarn

run_visibly tools/gradle :app:assembleRelease -Psigned -Psentry
# TODO(#5766): start passing -Psentry again
run_visibly tools/gradle :app:assembleRelease -Psigned
}

do_aab() {
check_yarn_link
run_visibly yarn

run_visibly tools/gradle :app:bundleRelease -Psigned -Psentry
# TODO(#5766): start passing -Psentry again
run_visibly tools/gradle :app:bundleRelease -Psigned
}

case "${action}" in
Expand Down

0 comments on commit 033a9d6

Please sign in to comment.