Increase module export annotations, where very easy. #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-some-annotations
branch
from
29010eb to
502a198
Compare
chrisbobbe
changed the title
These were found by temporarily setting `well_formed_exports=true` in the Flow config, as recommended in the Flow doc on Types-First: https://flow.org/en/docs/lang/types-first/. This will move us along toward Flow's new "Types-First" mode; switching entirely is zulip#4907.
… easy. These were found by temporarily setting `well_formed_exports=true` in the Flow config, as recommended in the Flow doc on Types-First: https://flow.org/en/docs/lang/types-first/. This will move us along toward Flow's new "Types-First" mode; switching entirely is zulip#4907.
gnprice
force-pushed
the
pr-some-annotations
branch
from
502a198 to
fe2fd9a
Compare
|
Looks good, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #4907. With
well_formed_exports=truetemporarily added in the.flowconfigunder[options](as suggested in the doc), this cuts the number of errors approximately in half; it's 396 to 205.