Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLHAlloc must return NULL when internal allocations fail #476

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ifakhrutdinov
Copy link
Contributor

Proposed changes

The SLHAlloc function keeps using the results of the internal allocations even when they're NULL which leads to S0C4 ABENDs. This commit makes SLHAlloc return NULL when the internal allocations fail.

This PR depends upon the following PRs: #475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Write an application which uses SLHAlloc; exhaust storage by reaching MEMLIMIT; SLHAlloc calls must return NULL and not ABEND.

Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

The SLHAlloc function keeps using the results of the internal
allocations even when they're NULL which leads to S0C4 ABENDs. This
commit makes SLHAlloc return NULL when the internal allocations fail.

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@JoeNemo JoeNemo merged commit 59be7a4 into v2.x/staging Aug 22, 2024
9 checks passed
@ifakhrutdinov ifakhrutdinov deleted the bugfix/slh-null-check branch August 22, 2024 20:34
@ifakhrutdinov ifakhrutdinov restored the bugfix/slh-null-check branch August 22, 2024 20:34
@ifakhrutdinov ifakhrutdinov deleted the bugfix/slh-null-check branch August 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants