Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IARV64 results need to be checked for 0x7FFFF000 #475

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ifakhrutdinov
Copy link
Contributor

Proposed changes

When MEMLIMIT is reached, IARV64 GETSTOR returns 0x7FFFF000; this conditions needs to be checked before memsetting.

Proposed changes

This PR addresses Issue: #474

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

See #474

When MEMLIMIT is reached, IARV64 GETSTOR returns 0x7FFFF000; this
conditions needs to be checked before memsetting.

Fixes: #474

Signed-off-by: Irek Fakhrutdinov <[email protected]>
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@JoeNemo JoeNemo merged commit 6d46ea2 into v2.x/staging Aug 22, 2024
9 checks passed
@ifakhrutdinov ifakhrutdinov deleted the bugfix/iarv64-0x7FFFF000 branch August 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants