Revert incorrect bump of Secrets SDK dev dep #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
requested review from
gejohnston,
zFernand0,
awharn,
traeok,
jace-roell and
ATorrise
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 638 638
Lines 19103 19103
Branches 4040 4041 +1
=======================================
Hits 17414 17414
Misses 1688 1688
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
awharn
approved these changes
Aug 9, 2024
gejohnston
approved these changes
Aug 9, 2024
t1m0thyj
added
the
release-current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Fixes the failing nightly workflow: https://github.com/zowe/zowe-cli-standalone-package/actions/runs/10311343832/job/28544753550
Related to zowe-actions/octorelease#147 which should prevent the issue from re-occurring
How to Test
Review Checklist
I certify that I have:
Additional Comments
We can probably combine this PR with #2215 as
release-patch😋