Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig and web help deps #2215

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Aug 6, 2024

⚠️ Don't merge until zowe-actions/octorelease#147 is published

What It Does

  • Enable declaration maps in tsconfig so that "Go to Definition" goes to .ts files instead of .d.ts files
  • Update web help dependencies for technical currency (including major update from Bootstrap 4 to 5)
  • Fix active node not updating in web help tree when browsing as a local file

How to Test

To test the tsconfig fix:

  1. Check out this branch and don't rebuild yet.
  2. Open a source file that imports classes from other SDKs (such as packages/zosuss/src/SshBaseHandler.ts).
  3. Ctrl+Click on one of the imported class names (e.g. ImperativeError) and notice a .d.ts file is opened.
  4. Rebuild , then Ctrl+Click the class name again and notice a .ts file is opened.

To test changes to web help, click on links in the doc and verify that active (highlighted) item in tree updates:
test-web-help-cropped

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (1e74449) to head (1c357e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2215   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files         638      638           
  Lines       19103    19103           
  Branches     3974     4041   +67     
=======================================
  Hits        17414    17414           
  Misses       1688     1688           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review August 6, 2024 20:24
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy for the updates!

@t1m0thyj t1m0thyj marked this pull request as draft August 8, 2024 15:26
@t1m0thyj t1m0thyj requested a review from traeok August 9, 2024 14:31
@t1m0thyj t1m0thyj marked this pull request as ready for review August 9, 2024 14:31
@t1m0thyj t1m0thyj requested a review from zFernand0 August 9, 2024 14:33
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever way to allow the rewriteShrinkwrap.js file to be executed from a different subpackage on the monorepo 😋

@t1m0thyj t1m0thyj added the needs-ported Indicates that a PR needs to be ported (master - lts-incremental) label Aug 9, 2024
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@t1m0thyj t1m0thyj merged commit 8fad1fa into master Aug 9, 2024
18 of 19 checks passed
@t1m0thyj t1m0thyj deleted the chore/update-dev-scripts branch August 9, 2024 19:46
@t1m0thyj t1m0thyj added the release-patch Indicates a patch to existing code has been applied label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ported Indicates that a PR needs to be ported (master - lts-incremental) release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants