Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding to zosfiles.messages for return message in ftp plugin #1831

Merged
merged 4 commits into from
Oct 24, 2023
Merged

adding to zosfiles.messages for return message in ftp plugin #1831

merged 4 commits into from
Oct 24, 2023

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Oct 20, 2023 •
edited
Loading

What It Does
Tiny change to be consistent with handler and test in the code region for a PR in the ftp-plugin, 142 . Rather than writing out error messages, import them from the cli's ZosFilesMessages

Review Checklist
I certify that I have:

@ATorrise ATorrise assigned awharn and unassigned awharn Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...ckages/zosfiles/src/constants/ZosFiles.messages.ts 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@ATorrise
adding a check for the existance of these constant files since they a…
0426b90 
…re dependencies for other processess

Signed-off-by: Amber Torrise <[email protected]>
@ATorrise
adding snapshot of constants
3e54086 
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise
adding changelog
ed36b9d 
Signed-off-by: Amber Torrise <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

zFernand0
zFernand0 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
I can't believe I'm saying this, but thanks for adding the snapshot 😋

@ATorrise
Copy link
Contributor Author

also added these changes to add-imp-v2 branch as commit b587eb2

@ATorrise ATorrise merged commit d74bddd into master Oct 24, 2023
28 checks passed
@ATorrise ATorrise deleted the addition_for_ftp-plugin branch October 24, 2023 14:07
@ATorrise ATorrise mentioned this pull request Oct 24, 2023
Merged
4 tasks
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Oct 24, 2023
@zFernand0
Copy link
Member

rerunning release workflow to bump the version number

@github-actions
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awharn awharn awharn approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@gejohnston gejohnston gejohnston approved these changes

@KevinLoesch1 KevinLoesch1 Awaiting requested review from KevinLoesch1

Assignees
No one assigned
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ATorrise @zFernand0 @gejohnston @awharn