-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix to disallow invalid characters in filenames #142
Conversation
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor comments. Thanks!
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment. Thanks, @ATorrise !
Signed-off-by: Amber Torrise <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zowe/cli
version update required
waiting for this workflow run to complete and for a new version out of this PR
Now we only need to update the CLI version: @zowe/[email protected]
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Provides a fix for issue143 by throwing an error when using invalid filenames so the progress bar doesn't loop indefinitely from the unhandled case of emojis and other invalid characters in dataset names. Depends on zowe-cli PR 1831 - unit tests will fail until this PR is merged in.
How to Test
Tested with the following
launch.json
configurationsReview Checklist
I certify that I have: