Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Bundle prebuilt daemon binaries in CLI package #1194

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 4, 2021

Resolves #1175

These changes were tested in another branch and produced this TGZ:
https://wash.zowe.org:8443/job/brightside/job/test-timothy/8/artifact/packages/cli/zowe-cli-7.0.0-next.202110211759.tgz

image

No changes were required to the files property in package.json - "prebuilds" was already listed there since we used it previously for bundling Keytar prebuilds.

"files": [
"lib",
"prebuilds",
"scripts",
"web-help-logo.png"
],

@t1m0thyj t1m0thyj linked an issue Nov 4, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #1194 (039da7c) into next-zowex-is-zowe (8836aa8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           next-zowex-is-zowe    #1194   +/-   ##
===================================================
  Coverage               91.67%   91.67%           
===================================================
  Files                     356      356           
  Lines                    5478     5478           
  Branches                  773      773           
===================================================
  Hits                     5022     5022           
  Misses                    451      451           
  Partials                    5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbef8dc...039da7c. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gejohnston gejohnston mentioned this pull request Nov 4, 2021
@t1m0thyj t1m0thyj merged commit e92398d into next-zowex-is-zowe Nov 5, 2021
@t1m0thyj t1m0thyj deleted the next-bundle-daemon branch November 5, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include binaries for Daemon Mode in core Zowe CLI
3 participants