Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next zowex is zowe #1114

Merged
merged 37 commits into from
Nov 11, 2021
Merged

Next zowex is zowe #1114

merged 37 commits into from
Nov 11, 2021

Conversation

gejohnston
Copy link
Member

@gejohnston gejohnston commented Aug 18, 2021

This PR enables 'zowex' to be named 'zowe'. This executable can:

  • Automatically start the daemon behind the scenes.
  • Eliminates the visible window associated with the daemon.
  • An environment variable named ZOWE_USE_DAEMON can be set to "no" to prevent the use of the daemon. The command is then passed to the traditional zowe-CLI command.
    • Thus, you can temporarily use the traditional Zowe CLI command to correct some display limitations (like displaying colors).

The majority of the changes associated with this PR (not merged in from other PRs) are contained in main.rs

This PR also fixes the following issues:

This PR should NOT be merged until:

Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Make five connection attempts.

Signed-off-by: Gene Johnston <[email protected]>
Add process information on connection failure.

Signed-off-by: Gene Johnston <[email protected]>
Return exit code of NodeJS zowe, when not using daemon.
Use simpler program launching techniques.
Add exit codes for failing to  launch programs.

Signed-off-by: Gene Johnston <[email protected]>
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1114 (705c1bf) into next (a6cdef2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1114   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         356      356           
  Lines        5478     5478           
  Branches      773      773           
=======================================
  Hits         5022     5022           
  Misses        451      451           
  Partials        5        5           
Impacted Files Coverage Δ
packages/core/src/apiml/Services.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b899e...705c1bf. Read the comment docs.

@gejohnston gejohnston marked this pull request as ready for review November 5, 2021 14:03
[next] Bundle prebuilt daemon binaries in CLI package
zFernand0
zFernand0 previously approved these changes Nov 8, 2021
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for documenting the outcome of the different approaches tried when starting the daemon.

t1m0thyj
t1m0thyj previously approved these changes Nov 8, 2021
zowex/src/main.rs Outdated Show resolved Hide resolved
@gejohnston gejohnston dismissed stale reviews from t1m0thyj and zFernand0 via 3e288b0 November 8, 2021 22:16
@zFernand0
Copy link
Member

PR LGTM!
Will approve after merge conflicts are resolved : )

zFernand0
zFernand0 previously approved these changes Nov 9, 2021
@zFernand0 zFernand0 requested a review from t1m0thyj November 9, 2021 17:23
t1m0thyj
t1m0thyj previously approved these changes Nov 10, 2021
dkelosky
dkelosky previously approved these changes Nov 11, 2021
@gejohnston gejohnston dismissed stale reviews from dkelosky, t1m0thyj, and zFernand0 via 705c1bf November 11, 2021 18:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gejohnston gejohnston merged commit d2535d1 into next Nov 11, 2021
@gejohnston gejohnston deleted the next-zowex-is-zowe branch November 11, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants