Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bundle Keytar in repackaging script #68

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Feb 2, 2022

This step is redundant once the following PRs are merged because Keytar is bundled in the package on NPM registry:

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t1m0thyj
Copy link
Member Author

t1m0thyj commented Feb 5, 2022

Merging to make the nightly Zowe CLI Bundle pipeline pass 🙂

@t1m0thyj t1m0thyj merged commit df28941 into master Feb 5, 2022
@t1m0thyj t1m0thyj deleted the prebuildify-keytar branch February 5, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants