This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Bundle prebuilds in the package on NPM registry #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
gejohnston
previously approved these changes
Feb 2, 2022
Signed-off-by: Timothy Johnson <[email protected]>
gejohnston
previously approved these changes
Feb 2, 2022
zFernand0
previously approved these changes
Feb 2, 2022
awharn
previously approved these changes
Feb 3, 2022
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
dismissed stale reviews from awharn, zFernand0, and gejohnston
via
adc50f7
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #53 and gives us the benefits mentioned in atom/node-keytar#255 by bundling native code in our NPM package.
We can use the Audit check on this PR to wait for GHSA-wpg7-2c88-r8xv to be resolved in Keytar.
To get the audit passing, we need to wait for one of these PRs to be merged and an update published: