VS Code Package Setup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
t1m0thyj
reviewed
Mar 13, 2023
Signed-off-by: Rudy Flores <[email protected]>
traeok
reviewed
Mar 13, 2023
There was a problem hiding this comment.
Wow, the caching for turbopack is neat. Thanks @rudyflores !
I noticed some errors when trying to run npm run package, will approve once fixed 😄
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path C:\Users\Trae\zowe-cli-secrets-for-kubernetes\dist\zowe-secrets-for-kubernetes-for-zowe-cli-1.0.0.tgz
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, open 'C:\Users\Trae\zowe-cli-secrets-for-kubernetes\dist\zowe-secrets-for-kubernetes-for-zowe-cli-1.0.0.tgz'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Trae\AppData\Local\npm-cache\_logs\2023-03-13T14_55_05_107Z-debug-0.log
npm ERR! Lifecycle script `package` failed with error:
npm ERR! Error: command failed
npm ERR! in workspace: @zowe/[email protected]
npm ERR! at location: C:\Users\Trae\zowe-cli-secrets-for-kubernetes\packages\cli
ENOENT: no such file or directory, open 'C:\Users\Trae\zowe-cli-secrets-for-kubernetes\dist\Zowe.secrets-for-kubernetes.vsix'
Signed-off-by: Rudy Flores <[email protected]>
Signed-off-by: Rudy Flores <[email protected]>
traeok
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
LGTM! Was able to install the extension and see the activation message. Thanks for clarifying on the missing dist folder @rudyflores 😄
t1m0thyj
reviewed
Mar 14, 2023
Signed-off-by: Rudy Flores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for VS Code package in the monorepo, currently this extension when installed only displays an information message for mentioning the extension has activated successfully, but is a good start to the upcoming work.
The VS Code package is handled with the following for bundling & minimizing:
The use of turbopack can build packages in the monorepo using caching now!
For testing try running the following:
npm installnpm run buildnpm run packageif you run
npm run buildseveral times you'll notice builds become faster and if changes are made it will dynamically bundle the necessary packages!Try testing installing both packages in the
/distfolder of the root directory, when installing thevsixit should display a message on the bottom right sayingExtension has activatedonce the extension activates (this is only for now for testing purposes).Extra: if clicking the play button in the
Run & Debugpanel in VS Code, it will open the development extension host which will allow testing of the extension and set breakpoints in future development of the repo!