-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating workflows and adding templates #12
Conversation
ATorrise
commented
May 8, 2023
Action | Description |
---|---|
#1 | add stale bot |
#2 | add auto-comment bot on labels |
#3 | add issue template (Bug, Feature) |
#4 | add PR Template |
#5 | add question redirect |
#6 | update all workflows to remove deprecation warnings, octorelease updates |
#7 | remove Node 14 from workflow matrix |
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating even commented out steps.
Left a few comments 😋
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes LGTM!
I'm not sure I know how to debug the failing system tests 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that the following PR is merged, I believe we can update the workflows to make sure there is a namespace when setting up the cluster
I believe @t1m0thyj may have some recommendations here
Adding this step to the workflow in between "Start K3s Cluster" and "Create System Test Properties" should fix it (source):
|
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
…editor Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.