Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: regression when opening a new File #321

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Fix: regression when opening a new File #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0342df8
fixing the logic to generate the mode uri
AdarshdeepCheema Feb 16, 2023
315a12c
fixing the logic to generate the mode uri
AdarshdeepCheema Feb 16, 2023
6514b9d
updating the changelog
AdarshdeepCheema Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Bugfix: Set USS path to correct directory, when opening the directory or file in new browser tab respectively
- Added the feature to copy the line content and copy URL link to open a file at a specific line
- Bugfix: Getting 400 BAD REQUEST in browser when opening the file or dataset in a new browser tab
- Bugfix: When opening New File, editor keeps on using the earlier opened file and its model

## `3.0.0`

Expand Down
3 changes: 1 addition & 2 deletions webClient/src/app/editor/code-editor/monaco/monaco.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,11 +537,10 @@ export class MonacoService implements OnDestroy {
}

generateUri(editorFile: ProjectStructure): string {
// have to use lowercase here!. This is uniquely identify the Editor Models
if(editorFile.isDataset){
return `inmemory://${editorFile.path.toLowerCase()}`;
} else{
return `inmemory://${editorFile.path.toLowerCase()}/${editorFile.name.toLowerCase()}`;
return `inmemory://${editorFile.name.toLowerCase()}/${editorFile.id}`;
}
}

Expand Down